From owner-freebsd-audit Sat Jul 14 21:29:10 2001 Delivered-To: freebsd-audit@freebsd.org Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by hub.freebsd.org (Postfix) with ESMTP id 2E1DF37B401; Sat, 14 Jul 2001 21:29:04 -0700 (PDT) (envelope-from brdavis@odin.ac.hmc.edu) Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.11.0/8.11.0) id f6F4St226647; Sat, 14 Jul 2001 21:28:55 -0700 Date: Sat, 14 Jul 2001 21:28:55 -0700 From: Brooks Davis To: Alexander Langer Cc: net@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: review request: if_faith modernization Message-ID: <20010714212855.B26269@Odin.AC.HMC.Edu> References: <20010714144147.A27610@Odin.AC.HMC.Edu> <20010715011143.A97334@fump.kawo2.rwth-aachen.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="Bn2rw/3z4jIqBvZU" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010715011143.A97334@fump.kawo2.rwth-aachen.de>; from alex@big.endian.de on Sun, Jul 15, 2001 at 01:11:44AM +0200 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --Bn2rw/3z4jIqBvZU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 15, 2001 at 01:11:44AM +0200, Alexander Langer wrote: > Thus spake Brooks Davis (brooks@one-eyed-alien.net): >=20 > People. This is a good example why style fixes shouldn't happen > with content fixes. I can't figure out what changed in this file: >=20 > > RCS file: /home/ncvs/src/sys/modules/Makefile,v > > retrieving revision 1.190 > > diff -u -r1.190 Makefile > > --- sys/modules/Makefile 2001/07/08 04:17:26 1.190 > > +++ sys/modules/Makefile 2001/07/13 23:10:49 dd pointed this out too. I just forgot that I had patched that. I'll commit it seperatly. (The actual change is adding if_faith.) > > diff -u -r1.6 if_faith.c > > --- sys/net/if_faith.c 2001/07/05 14:42:54 1.6 > > +++ sys/net/if_faith.c 2001/07/14 01:21:02 >=20 > I'm just curious: Why don't you need to include sys/module.h? > You don't include any other file that itself includes it, but > module.h defines DECLARE_MODULE and friends, which you are using. > I'm a little bit confused :-) I'm not sure. Things worked, so I didn't add more includes. > > +#include /* XXX: Shouldn't really be required! */ >=20 > Why do you include it then? :-) Because sys/rman.h bogusly contains refrences to bus_space_tag_t and bus_space_handle_t. The comment is actually brain's since that code is pretty much copyed from the cloning code for tun(4). Thanks, Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --Bn2rw/3z4jIqBvZU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE7URwFXY6L6fI4GtQRAr5QAJ9leEH0XDe3IVcUu/OXZtPHXLT3OwCfTEWo bfSvZKIoOWTgF+g2DQDi/i4= =epJb -----END PGP SIGNATURE----- --Bn2rw/3z4jIqBvZU-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message