From owner-svn-src-all@FreeBSD.ORG Sun Dec 29 09:01:05 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 524A8BA1; Sun, 29 Dec 2013 09:01:05 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E55F814B0; Sun, 29 Dec 2013 09:01:04 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id rBT90sMY073910; Sun, 29 Dec 2013 11:00:54 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua rBT90sMY073910 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id rBT90rL8073909; Sun, 29 Dec 2013 11:00:53 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 29 Dec 2013 11:00:53 +0200 From: Konstantin Belousov To: Alan Cox Subject: Re: svn commit: r259908 - head/sys/vm Message-ID: <20131229090053.GU59496@kib.kiev.ua> References: <201312260546.rBQ5kAoJ009798@svn.freebsd.org> <52BF6699.1040006@freebsd.org> <52BF7195.2070606@rice.edu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HrQ/+whymLRZ6Agu" Content-Disposition: inline In-Reply-To: <52BF7195.2070606@rice.edu> User-Agent: Mutt/1.5.22 (2013-10-16) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar , src-committers@freebsd.org, Nathan Whitehorn X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2013 09:01:05 -0000 --HrQ/+whymLRZ6Agu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 28, 2013 at 06:49:25PM -0600, Alan Cox wrote: > On 12/28/2013 18:02, Nathan Whitehorn wrote: > > On 12/26/13 00:46, Marcel Moolenaar wrote: > >> Author: marcel > >> Date: Thu Dec 26 05:46:10 2013 > >> New Revision: 259908 > >> URL: http://svnweb.freebsd.org/changeset/base/259908 > >> > >> Log: > >> For ia64, use pmap_remove_pages() and not pmap_remove(). The problem= is > >> that we don't have a good way (yet) to iterate over the mapped pages= by > >> virtual address and simply try each page within the range. Given tha= t we > >> call pmap_remove() over the entire 2^63 bytes of address space, it t= akes > >> a while for pmap_remove to have tried all 2^50 pages. > >> By using pmap_remove_pages() we use the PV list to find all mappings. > >> =20 > >> Change derived from a patch by: alc > >> > > Why make this ia64-specific? It seems like a potentially useful general > > optimization and certainly shouldn't be harmful on other architectures. >=20 > Some of the other implementations of pmap_remove_pages() have > limitations that don't permit them to be used for this purpose, e.g., >=20 > if (pmap !=3D PCPU_GET(curpmap)) { > printf("warning: pmap_remove_pages called with > non-current pmap\n"); > return; > } BTW, I do not easily see why the current amd64 implementation needs the pmap being current. I do not see accesses to recursive page table mappings in the code. --HrQ/+whymLRZ6Agu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSv+TFAAoJEJDCuSvBvK1BjDMP/R260PGrKF685fgY8O/3T/TX iSFJor7IsJ7p+dZn3HN/RRIhezOrSI6YstklcvU+XYfGAjRLpdkY7xAB8ugzddmv CRnGRtPrzizL3uMsPWWAvM47/hjV4w3nrE/AKuOJnLM2pPGx7VnRXTPrO66r6kS5 JigLu/PBHoQQ64EOn6V8w/+h0AI4HmFTIKNv3VD66Yfxlcyu55G5Kjxr2V+mqU6f EYLLinCUF5qbVVFTGOpHTClE563DIpTH/dM6B36ZiaEjPswWRbwUAJafkiWB7WYt AV9vO9/hb3lpPDHo44uXS2hAuVQ9HGxgYrwdbzR2HBFUZ9eS/lJDXhzHqeyUC/LY ZjB+qBy5cuYNWXGqks8Wbe21FCRkTy3lQv7aYyTLw52i/wixq5eKC5XrYmgP2/G4 RDBj9wavXoGP7lDAVWXX1KUMtEdzt47nSL/cAce3q7CVSA8+O/5QgXSj0XswPk5v 5je4Sdpv/X89oa3jn9dOxOzsTBhx3DYhuVGhKskbX7SoJPqvYO5Ke2P/2X+Somw9 GSBKfjqUhV5i9yJd4MJbSDaxy+PrKGrfTKeJfU4Y2dSLT3IKRvNP4TJEIOSBlWSo e9ciQ+W1gwIhB1Uc/+1PkeHAfgy5lCtKGZM+Sh+SN1yBo+DP7beebpImdHKth2pL zHBtXzbrFL3XY1YgR5bD =rj+C -----END PGP SIGNATURE----- --HrQ/+whymLRZ6Agu--