From owner-freebsd-usb@FreeBSD.ORG  Thu Oct 10 06:30:10 2013
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id CA3BAD50
 for <freebsd-usb@freebsd.org>; Thu, 10 Oct 2013 06:30:10 +0000 (UTC)
 (envelope-from hps@bitfrost.no)
Received: from mta.bitpro.no (mta.bitpro.no [92.42.64.202])
 by mx1.freebsd.org (Postfix) with ESMTP id 88848220F
 for <freebsd-usb@freebsd.org>; Thu, 10 Oct 2013 06:30:10 +0000 (UTC)
Received: from mail.lockless.no (mail.lockless.no [46.29.221.38])
 by mta.bitpro.no (Postfix) with ESMTP id B5C107A171;
 Thu, 10 Oct 2013 08:30:08 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by mail.lockless.no (Postfix) with ESMTP id 206D48F86DD;
 Thu, 10 Oct 2013 08:30:32 +0200 (CEST)
X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at lockless.no
Received: from mail.lockless.no ([127.0.0.1])
 by localhost (mail.lockless.no [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id h2b3BbKs34u8; Thu, 10 Oct 2013 08:30:31 +0200 (CEST)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 by mail.lockless.no (Postfix) with ESMTPSA id E26078F2C8D;
 Thu, 10 Oct 2013 08:30:30 +0200 (CEST)
Message-ID: <525649BB.2060906@bitfrost.no>
Date: Thu, 10 Oct 2013 08:31:23 +0200
From: Hans Petter Selasky <hps@bitfrost.no>
Organization: Bitfrost A/S
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130522 Thunderbird/17.0.6
MIME-Version: 1.0
To: "aseem.jolly" <aseem.jolly@gmail.com>
Subject: Re: USB device configuration
References: <1381274499940-5850403.post@n5.nabble.com>
 <5254FD72.2050507@bitfrost.no> <1381342263797-5850596.post@n5.nabble.com>
In-Reply-To: <1381342263797-5850596.post@n5.nabble.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-usb@freebsd.org
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Oct 2013 06:30:10 -0000

Hi,

On 10/09/13 20:11, aseem.jolly wrote:
> I couldn't really get the meaning of the following
> "Anyhow, if a second configure event fails after a successful one, we are
> still in the configured state".

It is allowed to set the configuration multiple times. Refer to USB 
2.0 specification.

>
> Are we making the following change
>
> done:
>        if (err)
>         unconfigure();
>        else
>         usb_set_device_state(udev, USB_STATE_CONFIGURED);

I have to do some more testing. Is this making a difference for you?

Right now 10-current is in a code-freeze, so you would have to remind me 
about this a bit later on.

Thank you for your comments!

--HPS