Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Nov 2007 01:27:08 +0000
From:      Nick Hilliard <nick-lists@netability.ie>
To:        "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
Cc:        freebsd-net@freebsd.org
Subject:   Re: tcp md5 checksums broken in 7.0-beta3
Message-ID:  <474CC3EC.1010205@netability.ie>
In-Reply-To: <20071126224649.C53707@maildrop.int.zabbadoz.net>
References:  <474B24F3.2030603@netability.ie> <20071126224649.C53707@maildrop.int.zabbadoz.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Bjoern A. Zeeb wrote:
> I'll try to find your bug the next days (in case you find anything let
> me know).

At the very least, this will be necessary:

--- tcp_subr.c~        2007-11-28 01:14:46.000000000 +0000
+++ tcp_subr.c  2007-11-28 01:14:46.000000000 +0000
@@ -1948,7 +1948,7 @@
        /*
         * Step 4: Update MD5 hash with shared secret.
         */
-       MD5Update(&ctx, _KEYBUF(sav->key_auth), _KEYLEN(sav->key_auth));
+       MD5Update(&ctx, sav->key_auth->key_data, _KEYLEN(sav->key_auth));
        MD5Final(buf, &ctx);

        key_sa_recordxfer(sav, m);

But it doesn't fix the problem.

Nick



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?474CC3EC.1010205>