From owner-svn-src-head@freebsd.org Fri May 4 19:43:42 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 915FCFB65CC for ; Fri, 4 May 2018 19:43:42 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 194CF82CC9 for ; Fri, 4 May 2018 19:43:41 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 6b2fe5c7-4fd3-11e8-8e23-5bc9f169c8f5 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id 6b2fe5c7-4fd3-11e8-8e23-5bc9f169c8f5; Fri, 04 May 2018 19:43:31 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w44JhT67048339; Fri, 4 May 2018 13:43:29 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1525463009.57768.281.camel@freebsd.org> Subject: Re: svn commit: r333261 - head/sys/conf From: Ian Lepore To: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 04 May 2018 13:43:29 -0600 In-Reply-To: <201805041931.w44JVS3d096407@repo.freebsd.org> References: <201805041931.w44JVS3d096407@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 19:43:42 -0000 On Fri, 2018-05-04 at 19:31 +0000, Matt Macy wrote: > Author: mmacy > Date: Fri May  4 19:31:28 2018 > New Revision: 333261 > URL: https://svnweb.freebsd.org/changeset/base/333261 > > Log: >   % WITHOUT_FORMAT_EXTENSIONS=  XCC=/usr/local/bin/gcc8 make -j96 > buildkernel KERNCONF=GENERIC-NODEBUG -s >& log >   % grep "inlining failed" log | wc >        234    3570   36065 >   Consensus on those polled is that inlining failure warnings are not > useful >    >   Approved by: sbruno This is another marginal commit message. A good commit messages starts with a sentence or two that summarizes what's been changed, followed by some non-zero amount of extra information that says why (for all but the most trivial self-obvious changes). This is pretty good on the "why". Consider how this is going to look buried in the output of "svn log kern.mk" (or on svnweb.freebsd.org) when you're skimming through the commit history looking for what changed while you're tracking down some problem. When you run into this commit in the log, you're going to have no option but to stop what you're doing and look at the diff to see if it's germane to your search, because of the missing summary information. -- Ian