From owner-cvs-usrbin  Mon Jul 15 14:59:33 1996
Return-Path: owner-cvs-usrbin
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id OAA20201
          for cvs-usrbin-outgoing; Mon, 15 Jul 1996 14:59:33 -0700 (PDT)
Received: from mail.cs.tu-berlin.de (root@mail.cs.tu-berlin.de [130.149.17.13])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id OAA20157;
          Mon, 15 Jul 1996 14:58:23 -0700 (PDT)
Received: from campa.panke.de (anonymous231.ppp.cs.tu-berlin.de [130.149.17.231]) by mail.cs.tu-berlin.de (8.6.12/8.6.12) with ESMTP id XAA12182; Mon, 15 Jul 1996 23:37:29 +0200
Received: (from wosch@localhost) by campa.panke.de (8.6.12/8.6.12) id XAA00791; Mon, 15 Jul 1996 23:32:43 +0200
Date: Mon, 15 Jul 1996 23:32:43 +0200
From: Wolfram Schneider <wosch@cs.tu-berlin.de>
Message-Id: <199607152132.XAA00791@campa.panke.de>
To: Bruce Evans <bde@zeta.org.au>
Cc: pst@shockwave.com, thorpej@nas.nasa.gov,
        CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-usrbin@freefall.freebsd.org, nate@freefall.freebsd.org
Subject: Re: cvs commit: src/usr.bin/rdist defs.h docmd.c expand.c lookup.c server.c
In-Reply-To: <199607142351.JAA10509@godzilla.zeta.org.au>
References: <199607142351.JAA10509@godzilla.zeta.org.au>
Reply-to: Wolfram Schneider <wosch@cs.tu-berlin.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: owner-cvs-usrbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Bruce Evans writes:
>>It may be overboard, but it certainly doesn't _hurt_ :-)
>
>It may give a false sense of security.

Thats life. You close the front door and the burglar use the window
or kidnaps your children.


>> >   Should we disable sprintf() for sgid/suid programs?
>
>Why stop there?  Convert all strcpy()s to snprintf()s.  

Hm, Paul already started ;-) Why waiting for next CERT report? We have
~77 suid/sgid programs (total ~584 programs). Of course to much s-bits.


>pst         96/07/15 09:29:04
>
>  Modified:    usr.bin/rlogin  rlogin.c
>  Log:
>  Do a bounds check on the strcpy of environment variables onto the stack.
>  
>  Revision  Changes    Path
>  1.11      +1 -1      src/usr.bin/rlogin/rlogin.c

Wolfram