From owner-svn-src-all@FreeBSD.ORG  Tue Oct 29 19:21:33 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 2589AFD;
 Tue, 29 Oct 2013 19:21:33 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au
 [211.29.132.246])
 by mx1.freebsd.org (Postfix) with ESMTP id DB67A2F11;
 Tue, 29 Oct 2013 19:21:32 +0000 (UTC)
Received: from c122-106-156-23.carlnfd1.nsw.optusnet.com.au
 (c122-106-156-23.carlnfd1.nsw.optusnet.com.au [122.106.156.23])
 by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 01E7B422219;
 Wed, 30 Oct 2013 05:54:31 +1100 (EST)
Date: Wed, 30 Oct 2013 05:54:30 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Mark Johnston <markj@FreeBSD.org>
Subject: Re: svn commit: r257298 - head/lib/libproc
In-Reply-To: <20131029152905.GA2652@charmander.sandvine.com>
Message-ID: <20131030055021.H2325@besplex.bde.org>
References: <201310290312.r9T3CVx4064237@svn.freebsd.org>
 <20131029235717.M905@besplex.bde.org>
 <20131029152905.GA2652@charmander.sandvine.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=DstvpgP+ c=1 sm=1 tr=0
 a=ebeQFi2P/qHVC0Yw9JDJ4g==:117 a=PO7r1zJSAAAA:8 a=OlY6O5FfQTkA:10
 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8 a=c1kkC1SkZDMA:10
 a=7B3j6aZmG816uNN3KPIA:9 a=CjuIK1q_8ugA:10
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2013 19:21:33 -0000

On Tue, 29 Oct 2013, Mark Johnston wrote:

> On Wed, Oct 30, 2013 at 12:21:28AM +1100, Bruce Evans wrote:
>> On Tue, 29 Oct 2013, Mark Johnston wrote:
>>
>>> Log:
>>>  Revert r257248 and fix the problem in a way that doesn't violate style(9).
>>
>> Why did gcc complain about the original version?
>
> It looks like this is because of the use of -W, which is apparently an
> alias for -Wextra; according to the gcc man page, this will trigger a
> warning when "an empty body occurs in an if or else statement."

Thanks.  I have -W in some CFLAGS but never noticed this behaviour before.

Bruce