From nobody Thu Mar 24 19:51:27 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id CB8231A31A85 for ; Thu, 24 Mar 2022 19:51:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KPbSv33Wwz4S1C for ; Thu, 24 Mar 2022 19:51:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 49E7C1E5BA for ; Thu, 24 Mar 2022 19:51:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 22OJpRhX015831 for ; Thu, 24 Mar 2022 19:51:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 22OJpRXN015830 for bugs@FreeBSD.org; Thu, 24 Mar 2022 19:51:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 262515] Missing filecaps_free() in many places Date: Thu, 24 Mar 2022 19:51:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mjg@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648151487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I3TKaAmMu1ws6fR0IwW4jS6bEy02xyFFHsJF46lanzU=; b=dph+H2zRF5Riv8XdQ6kglFQaM/7VInBPncfxcaJOrRi1d2BmbIN5hSaNEGY56W5wJWtKuH czO4KqGjpKXDjp9RO7ocesTYGmSgTu0IlCu39zJp5fzaFsat8qLT7KfvSZpzmlegCbWWEF EmQmpHjJZLRGnOEOax1qYhGSEYrKHP98RU4jUkWxKRuO2MPUzmlFadUKLB3eOR5rxYDX2t bNru4U0l0YBAXag7E3oayCobCev7MNtyAez/Qfh3arbLO4YbBiSEWSDAEOrdMD+kGUcfCF pRazUDM7nPKs4AZIYxWynqrlpcTiBctuXi43cOCP/g0GLf/65NkWGSdfrhGqiw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648151487; a=rsa-sha256; cv=none; b=TDtCxQwm8XW5u9K75APaM/4Ql62TV8byYpl8s2nFuLvjBqAZ1VF76mp5TgcaKZLaUP3mJ2 HnoKp/6pleOivTlsMQDGaB5tvo9RxaOGEkqPzZkF8oeOaS19M88iAG3mQB5kYCabmSsoCR E+9Rr4U9PQFOXkbFKSMNIsfciYMfcvt1alW4bKtkLYm20NqCQC+rT4dT6fyww1vCfQ0Kwi d0i09HMpwLTF8KAJRyJdhxvu6Ta1FBfPW6vwaTa276m4Z4njEW/moQx/P0adKHUODjrdRn jpF6P2eXbb9Mw7AVS10cl4C7MweLgs+nxC6I5kJc3Jx7XlB4Q2q+2Inmzi2k1A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262515 --- Comment #4 from Mateusz Guzik --- I agree it should be on demand, but I have further notes. 1. fd-related code in namei_setup needs to be factored away to kern_descrip= .c. 2. if the caller does not care to look at caps, we can make a copy without allocating anything (and subsequently without having to free anything). as shown in the reproducer, the only part which requires malloc is ioctl handl= ing, but ioctls are not inspected in the lookup itself. 3. instead of direct filecaps_free perhaps NDFREE_CAPS or similar should be provided I'll sleep on it and probably hack it up over the weekend. It will be mfcab= le. --=20 You are receiving this mail because: You are the assignee for the bug.=