From owner-freebsd-qa Wed Nov 20 7:30:45 2002 Delivered-To: freebsd-qa@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F32A837B401 for ; Wed, 20 Nov 2002 07:30:43 -0800 (PST) Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD99543E42 for ; Wed, 20 Nov 2002 07:30:35 -0800 (PST) (envelope-from john@baldwin.cx) Received: (qmail 15302 invoked from network); 20 Nov 2002 15:30:37 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 20 Nov 2002 15:30:37 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id gAKFUX2D034682 for ; Wed, 20 Nov 2002 10:30:33 -0500 (EST) (envelope-from john@baldwin.cx) Received: from laptop.baldwin.cx (localhost [127.0.0.1]) by laptop.baldwin.cx (8.12.6/8.12.5) with ESMTP id gAKFUbjB001580 for ; Wed, 20 Nov 2002 10:30:38 -0500 (EST) (envelope-from john@laptop.baldwin.cx) Received: (from john@localhost) by laptop.baldwin.cx (8.12.6/8.12.6/Submit) id gAKFUbjG001578 for qa@FreeBSD.org; Wed, 20 Nov 2002 10:30:37 -0500 (EST) Date: Wed, 20 Nov 2002 10:30:37 -0500 (EST) From: John Baldwin Message-Id: <200211201530.gAKFUbjG001578@laptop.baldwin.cx> To: qa@FreeBSD.org Subject: sysinstall fstab bug Sender: owner-freebsd-qa@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG sysinstall currently is using /dev/acd0c for /cdrom in the /etc/fstab it generates, but in 5.0 it should really be using /dev/acd0 w/o using a "fake" BSD 'c' partition. I think this patch will fix it but it hasn't been tested yet. Index: devices.c =================================================================== RCS file: /usr/cvs/src/usr.sbin/sysinstall/devices.c,v retrieving revision 1.142 diff -u -r1.142 devices.c --- devices.c 13 Nov 2002 05:39:57 -0000 1.142 +++ devices.c 20 Nov 2002 15:20:53 -0000 @@ -61,13 +61,13 @@ char *description; int major, minor, delta, max; } device_names[] = { - { DEVICE_TYPE_CDROM, "cd%dc", "SCSI CDROM drive", 15, 2, 8, 4 }, - { DEVICE_TYPE_CDROM, "mcd%da", "Mitsumi (old model) CDROM drive", 29, 0, 8, 4 }, - { DEVICE_TYPE_CDROM, "scd%da", "Sony CDROM drive - CDU31/33A type", 45, 0, 8, 4 }, + { DEVICE_TYPE_CDROM, "cd%d", "SCSI CDROM drive", 15, 2, 8, 4 }, + { DEVICE_TYPE_CDROM, "mcd%d", "Mitsumi (old model) CDROM drive", 29, 0, 8, 4 }, + { DEVICE_TYPE_CDROM, "scd%d", "Sony CDROM drive - CDU31/33A type", 45, 0, 8, 4 }, #ifdef notdef - { DEVICE_TYPE_CDROM, "matcd%da", "Matsushita CDROM ('sound blaster' type)", 46, 0, 8, 4 }, + { DEVICE_TYPE_CDROM, "matcd%d", "Matsushita CDROM ('sound blaster' type)", 46, 0, 8, 4 }, #endif - { DEVICE_TYPE_CDROM, "acd%dc", "ATAPI/IDE CDROM", 117, 0, 8, 4 }, + { DEVICE_TYPE_CDROM, "acd%d", "ATAPI/IDE CDROM", 117, 0, 8, 4 }, { DEVICE_TYPE_TAPE, "rsa%d", "SCSI tape drive", 14, 0, 16, 4 }, { DEVICE_TYPE_TAPE, "rwt%d", "Wangtek tape drive", 10, 0, 1, 4 }, { DEVICE_TYPE_DISK, "da%d", "SCSI disk device", 13, 65538, 8, 16 }, -- John Baldwin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-qa" in the body of the message