Date: 11 Nov 2007 17:25:10 +0100 From: "Arno J. Klaassen" <arno@heho.snv.jussieu.fr> To: =?iso-8859-1?q?S=F8ren_Schmidt?= <sos@deepcore.dk>, Alexander Sabourenkov <screwdriver@lxnt.info> Cc: Nathan Butcher <n-butcher@fusiongol.com>, freebsd-current@freebsd.org Subject: Re: Remaining SATA (and other) issues TAKE 2 Message-ID: <wpy7d43g2h.fsf@heho.snv.jussieu.fr> In-Reply-To: <4736DC08.3030809@deepcore.dk> References: <47326FB8.50602@fusiongol.com> <4732CEE3.3070003@lxnt.info> <4732DA32.3090601@deepcore.dk> <4732E18A.6040802@lxnt.info> <4732E37F.9020707@deepcore.dk> <4732E7C2.3030403@lxnt.info> <4736DC08.3030809@deepcore.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Søren, Alexander,
> Alexander found the bug causing the data to be offset wrongly in my
> last patch, this new one should fix that so we dont get disappearing
> nodes etc, sorry about that :)
>
> Please apply to clean releng_7 sources.
>
> Let me know how it turns out.
I still test first on releng_6, but initial testing indicates
it solves my problems.
Thank you very much!
NB, I still get an error in ata_pci_attach() when
bus_alloc_resource_any() for ATA_BMADDR_RID :
pci0: child atapci0 requested type 4 for rid 0x20, but the BAR says it is an memio
When I retry with "ctlr->r_type1 = SYS_RES_MEMORY" (diff attached)
it says :
atapci0: Reserved 0x20000 bytes for rid 0x20 type 3 at 0xfba00000
which it anyway says as well a bit later when attaching :
ioapic0: routing intpin 18 (PCI IRQ 18) to vector 49
atapci0: [MPSAFE]
atapci0: Reserved 0x20000 bytes for rid 0x20 type 3 at 0xfba00000
atapci0: Reserved 0x1000 bytes for rid 0x1c type 3 at 0xfbb00000
atapci0: [MPSAFE]
Just if ever this info helps you; the failing bus_alloc_resource_any()
for ATA_BMADDR_RID does not seem to have any influence.
Once again thanx.
Best, Arno
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=ata_bmaddr_rid.patch
Index: ata-pci.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-pci.c,v
retrieving revision 1.105.2.6
diff -u -r1.105.2.6 ata-pci.c
--- ata-pci.c 9 Nov 2007 09:58:08 -0000 1.105.2.6
+++ ata-pci.c 11 Nov 2007 15:58:07 -0000
@@ -212,6 +212,17 @@
ctlr->r_rid1 = ATA_BMADDR_RID;
ctlr->r_res1 = bus_alloc_resource_any(dev, ctlr->r_type1, &ctlr->r_rid1,
RF_ACTIVE);
+ /* ARNO some bios + TX4 claim memio iso portio */
+ if ( (ctlr->r_res1 == NULL) && (ctlr->chip->chipid == ATA_PDC40718) ) {
+ device_printf(dev,
+ " ARNO TX4 fails ioport for rid %#x\n"
+ " retry with memio .. \n", ATA_BMADDR_RID);
+ ctlr->r_type1 = SYS_RES_MEMORY;
+ ctlr->r_res1 = bus_alloc_resource_any(dev, ctlr->r_type1,
+ &ctlr->r_rid1, RF_ACTIVE);
+ if (ctlr->r_res1 == NULL) device_printf(dev, " ARNO memio KO\n");
+ else device_printf(dev, " ARNO memio OK!\n");
+ }
}
if (ctlr->chipinit(dev))
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?wpy7d43g2h.fsf>