From owner-cvs-all Wed May 15 6: 7:12 2002 Delivered-To: cvs-all@freebsd.org Received: from green.bikeshed.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 8065137B408; Wed, 15 May 2002 06:07:02 -0700 (PDT) Received: from localhost (green@localhost) by green.bikeshed.org (8.11.6/8.11.6) with ESMTP id g4FD71651437; Wed, 15 May 2002 09:07:02 -0400 (EDT) (envelope-from green@green.bikeshed.org) Message-Id: <200205151307.g4FD71651437@green.bikeshed.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Maxim Sobolev Cc: Brian Feldman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/www/mozilla Makefile pkg-plist In-Reply-To: Your message of "Wed, 15 May 2002 09:34:31 +0300." <3CE20177.BF50736D@FreeBSD.org> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 15 May 2002 09:07:01 -0400 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Maxim Sobolev wrote: > Brian Feldman wrote: > > > > green 2002/05/14 20:57:17 PDT > > > > Modified files: > > www/mozilla Makefile pkg-plist > > Log: > > Don't treat the ${WITHOUT_CHATZILLA} (default) build as gratuitously > > different from the one with ChatZilla. This means building otherwise > > the exact same extensions. > > Thank you for your patch, but *please* next time when you are about to > commit something into any port maintained by gnome@FreeBSD.org pass > your patches through maintainer. This is expecially important before > release, when an occasional mistake could vanish work done by many > individuals. In this particular case I suspect that your change broke > mozilla-headers, as xmlterm extension adds its own headers into the > mix, so that you also need to adjust mozilla-headers/pkg-plist. Please > do it ASAP. I don't believe anything broke, since I was able to successfully package both of the ports. In any case, I'm sorry about that; I was under the mistaken impression that the mailing-list MAINTAINERs in ports were unlike conventional ones. You're right, though; since mozilla-headers should include xmlterm since it's now required in both cases, I'll add that. > Since you was not aware about this policy, I let your change remain in > the tree, but please note that next time any unapproved changes will > be reverted unconditionally by me or any other member of FreeBSD GNOME > team. > > Thanks! You've gotten me curious -- why is Mozilla a "gnome" port? It's almost entirely unrelated... -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message