From owner-freebsd-cvsweb@FreeBSD.ORG Mon Dec 22 18:29:45 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E563116A4CE; Mon, 22 Dec 2003 18:29:45 -0800 (PST) Received: from mail.alternation.net (CPE0080c80c52fd-CM.cpe.net.cable.rogers.com [24.230.212.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BC1843D31; Mon, 22 Dec 2003 18:29:44 -0800 (PST) (envelope-from brian@alternation.net) Received: by mail.alternation.net (Postfix, from userid 99) id 32EE01B5A8; Mon, 22 Dec 2003 22:21:43 -0400 (AST) Received: from alternation.net (CPE0080c80c52fd-CM.cpe.net.cable.rogers.com [24.230.212.16]) by mail.alternation.net (Postfix) with ESMTP id 09CD61B0ED; Mon, 22 Dec 2003 22:21:02 -0400 (AST) Message-ID: <3FE7A864.8010204@alternation.net> Date: Mon, 22 Dec 2003 22:28:52 -0400 From: Brian Cassidy User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031215 Thunderbird/0.5a (MozJF) X-Accept-Language: en-us, en MIME-Version: 1.0 To: =?ISO-8859-1?Q?Ville_Skytt=E4?= References: <3FD8F532.2060302@alternation.net> <1072129067.25251.179.camel@bobcat.mine.nu> In-Reply-To: <1072129067.25251.179.camel@bobcat.mine.nu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on maelstrom.alternation.net X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.60 cc: freebsd-cvsweb@FreeBSD.org Subject: Re: diff crashes under mod_perl X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Dec 2003 02:29:46 -0000 Hi Ville, Thanks for responding. Ville Skyttä wrote: > On Fri, 2003-12-12 at 00:52, Brian Cassidy wrote: > > >>I'm using the most recent cvsweb beta. Apache 2.0.48. perl 5.8.0. >>mod_perl 1.99_10. > > > Hm, I have the same setup, except Perl 5.8.1 and mod_perl 1.99_09. Before i say anything about what you've said below, I decided to upgrade my mod_perl installation to 1.99_12 (released today). That appears to have cleared my problems. Diffs work as advertised. >>Viewing a diff produces the following entry in the apache error_log: > > > Did the diff still appear correctly in the browser? > Nope. >>[Thu Dec 11 18:52:53 2003] [error] 14871: ModPerl::Registry: $r wasn't >>passed at /home/httpd/cvs/cvs.cgi line 2238. > > > I cannot reproduce that. Line 2238 in 2.9.1 contains > "openOutputFilter()", which should be a no-op unless you have > $output_filter defined in cvsweb.conf. I couldn't reproduce the error > even when setting up a trivial output filter like > > $output_filter= '/usr/bin/tr "[a-zA-Z]" "_"'; > > Could you check if you have $output_filter set and if you need it, and > whether disabling it affects this? I'll try to upgrade my mod_perl > soonish... I first tried that output filter from your email without success. I then went on to upgrade mod_perl and all was well. I guess I'll chalk that up to a bug in that version of mod_perl. Thanks, -Brian