From owner-freebsd-threads@FreeBSD.ORG Fri Oct 29 20:25:09 2004 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C1E7716A4CE; Fri, 29 Oct 2004 20:25:09 +0000 (GMT) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 300EF43D3F; Fri, 29 Oct 2004 20:25:09 +0000 (GMT) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) i9TKOwIo010931; Fri, 29 Oct 2004 16:24:58 -0400 (EDT) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id i9TKOw7F010930; Fri, 29 Oct 2004 16:24:58 -0400 (EDT) Date: Fri, 29 Oct 2004 16:24:58 -0400 From: Ken Smith To: Julian Elischer Message-ID: <20041029202458.GE9533@electra.cse.Buffalo.EDU> References: <41817EE4.9080302@elischer.org> <20041029010822.GA12081@electra.cse.Buffalo.EDU> <20041029040931.GA920@frontfree.net> <4182A431.2050001@elischer.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4182A431.2050001@elischer.org> User-Agent: Mutt/1.4.1i cc: re@freebsd.org cc: John Baldwin cc: Daniel Eischen cc: David Xu cc: threads@freebsd.org cc: Ken Smith Subject: Re: MFC req for 5.x/5.3 X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2004 20:25:09 -0000 On Fri, Oct 29, 2004 at 01:12:33PM -0700, Julian Elischer wrote: > Xin LI wrote: > >Hi, Ken, > > > >On Thu, Oct 28, 2004 at 09:08:22PM -0400, Ken Smith wrote: > > > > > >>>>>>Revision Changes Path > >>>>>>1.58 +1 -0 src/lib/libpthread/thread/thr_create.c > >>>>>>1.14 +1 -1 src/lib/libpthread/thread/thr_find_thread.c > >>>>>>1.115 +27 -10 src/lib/libpthread/thread/thr_kern.c > >>>>>>1.119 +15 -11 src/lib/libpthread/thread/thr_private.h > >>>>>>1.81 +1 -2 src/lib/libpthread/thread/thr_sig.c > >>>>>> > >>>>>> > > > >JFYI: I have tested that a RELENG_5 with ``cvs up -A'' in > >src/lib/libpthread/ > >works quite well and I have tested these on my notebook (P4-M based). > > > > though this is not equivalent to doing a -A.. there are a few minor > differences not being MFC'd.. Yup. That's why I thought we would need to be a little bit careful with this, it's a bit more complicated than it first seems. There is a chance for example that a piece that's not being MFC-ed added an extra #include and if the new code that's being MFC-ed relies on that it can be a bit tough to catch with the first attempt. My asking for caution on this wasn't a reflection on Julian, I'd ask anyone to be this careful about this particular MFC because it doesn't look like it's a straight "MFC everything". And doing an "MFC everything" for a library like this is risky at the RC2 stage, it's possible pieces of what gets swept in could have an impact (possibly negative) on the packages that use it. It would be a bit of a gamble. Thanks for your work on this guys. Greatly appreciated. -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel |