From owner-freebsd-current Sat May 30 20:56:57 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA25467 for freebsd-current-outgoing; Sat, 30 May 1998 20:56:57 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from antipodes.cdrom.com (castles307.castles.com [208.214.167.7]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA25461 for ; Sat, 30 May 1998 20:56:55 -0700 (PDT) (envelope-from mike@antipodes.cdrom.com) Received: from antipodes.cdrom.com (localhost [127.0.0.1]) by antipodes.cdrom.com (8.8.8/8.8.5) with ESMTP id TAA08893; Sat, 30 May 1998 19:52:37 -0700 (PDT) Message-Id: <199805310252.TAA08893@antipodes.cdrom.com> X-Mailer: exmh version 2.0zeta 7/24/97 To: "John W. DeBoskey" cc: freebsd-current@FreeBSD.ORG Subject: Re: cdrecord & core dumps In-reply-to: Your message of "Sat, 30 May 1998 22:23:03 EDT." <199805310223.AA23531@mozart> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 30 May 1998 19:52:37 -0700 From: Mike Smith Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > First of all, the following code is incorrect for FreeBSD. > _SC_PAGESIZE is defined in the header files, but it is not supported > via sysconf(), hence pagesize gets set to -1. > > In init_fifo() (fifo.c) > > #ifdef _SC_PAGESIZE > pagesize = sysconf(_SC_PAGESIZE); > #else > pagesize = getpagesize(); > #endif I've actually patched this to: int pagesize = -1; #ifdef _SC_PAGESIZE pagesize = sysconf(_SC_PAGESIZE); #endif if (pagesize == -1) pagesize = getpagesize(); Which is about as readable as is reasonable. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message