From owner-freebsd-doc@FreeBSD.ORG Sat Apr 10 09:10:14 2004 Return-Path: Delivered-To: freebsd-doc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C478316A4CE for ; Sat, 10 Apr 2004 09:10:14 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B6A5C43D48 for ; Sat, 10 Apr 2004 09:10:14 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i3AGAEbv046130 for ; Sat, 10 Apr 2004 09:10:14 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i3AGAEgS046129; Sat, 10 Apr 2004 09:10:14 -0700 (PDT) (envelope-from gnats) Resent-Date: Sat, 10 Apr 2004 09:10:14 -0700 (PDT) Resent-Message-Id: <200404101610.i3AGAEgS046129@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-doc@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Roman Neuhauser Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A725D16A4CE for ; Sat, 10 Apr 2004 09:02:25 -0700 (PDT) Received: from smtp.dkm.cz (smtp.dkm.cz [62.24.64.34]) by mx1.FreeBSD.org (Postfix) with SMTP id 85F2B43D31 for ; Sat, 10 Apr 2004 09:02:24 -0700 (PDT) (envelope-from neuhauser@chello.cz) Received: (qmail 22105 invoked by uid 0); 10 Apr 2004 16:02:23 -0000 Received: from r3al16.mistral.cz (HELO isis.wad.cz) (213.220.229.16) by smtp.dkm.cz with SMTP; 10 Apr 2004 16:02:23 -0000 Received: by isis.wad.cz (Postfix, from userid 1001) id 345D32FDA01; Sat, 10 Apr 2004 17:02:52 +0200 (CEST) Message-Id: <20040410150252.345D32FDA01@isis.wad.cz> Date: Sat, 10 Apr 2004 17:02:52 +0200 (CEST) From: Roman Neuhauser To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: docs/65400: make.1: better wording in BUGS section X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Apr 2004 16:10:15 -0000 >Number: 65400 >Category: docs >Synopsis: make.1: better wording in BUGS section >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-doc >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Apr 10 09:10:14 PDT 2004 >Closed-Date: >Last-Modified: >Originator: Roman Neuhauser >Release: FreeBSD 4.9-RELEASE-p2 i386 >Organization: >Environment: System: FreeBSD isis.wad.cz 4.9-RELEASE-p2 FreeBSD 4.9-RELEASE-p2 #3: Sun Mar 7 02:11:16 CET 2004 root@isis.wad.cz:/usr/obj/usr/src/sys/FREEPUPPY2_6 i386 >Description: the make manual page says: For loops are expanded before tests, so a fragment such as: .for TMACHINE in ${SHARED_ARCHS} .if ${TMACHINE} = ${MACHINE} ... .endif .endfor won't work, and should be rewritten the other way around. This formulation isn't as clear as it could be, it sounds like the loop should be inside the condition. I know it confused me when I was trying to learn make, and recently saw someone else's post about the same thing on one of the lists. >How-To-Repeat: >Fix: The attached shar contains patches for both CURRENT and RELENG_4. --- src::usr.bin::make::make.1.shar begins here --- # This is a shell archive. Save it in a file, remove anything before # this line, and then unpack it by entering "sh file". Note, it may # create directories; files and directories will be owned by you and # have default permissions. # # This archive contains: # # /home/roman/codex/patches/FreeBSD/make.1.CURRENT.patch # /home/roman/codex/patches/FreeBSD/make.1.STABLE.patch # echo x - /home/roman/codex/patches/FreeBSD/make.1.CURRENT.patch sed 's/^X//' >/home/roman/codex/patches/FreeBSD/make.1.CURRENT.patch << 'END-of-/home/roman/codex/patches/FreeBSD/make.1.CURRENT.patch' XIndex: make.1 X=================================================================== XRCS file: /home/ncvs/src/usr.bin/make/make.1,v Xretrieving revision 1.66 Xdiff -u -r1.66 make.1 X--- make.1 21 Jan 2004 17:58:33 -0000 1.66 X+++ make.1 10 Apr 2004 14:31:14 -0000 X@@ -1260,7 +1260,7 @@ X \&.endfor X .Ed X .Pp X-won't work, and should be rewritten the other way around. X+won't work, and should be rewritten with the operands swapped. X .Pp X The parsing code is broken with respect to handling a semicolon X after a colon, so a fragment like this will fail: END-of-/home/roman/codex/patches/FreeBSD/make.1.CURRENT.patch echo x - /home/roman/codex/patches/FreeBSD/make.1.STABLE.patch sed 's/^X//' >/home/roman/codex/patches/FreeBSD/make.1.STABLE.patch << 'END-of-/home/roman/codex/patches/FreeBSD/make.1.STABLE.patch' XIndex: make.1 X=================================================================== XRCS file: /home/ncvs/src/usr.bin/make/make.1,v Xretrieving revision 1.29.2.15 Xdiff -u -r1.29.2.15 make.1 X--- make.1 17 Dec 2002 19:01:18 -0000 1.29.2.15 X+++ make.1 10 Apr 2004 14:36:27 -0000 X@@ -1265,7 +1265,7 @@ X \&.endif X \&.endfor X .Ed X-won't work, and should be rewritten the other way around. X+won't work, and should be rewritten with the operands swapped. X .Sh SEE ALSO X .Xr mkdep 1 , X .Xr make.conf 5 END-of-/home/roman/codex/patches/FreeBSD/make.1.STABLE.patch exit --- src::usr.bin::make::make.1.shar ends here --- >Release-Note: >Audit-Trail: >Unformatted: