From owner-freebsd-ports@FreeBSD.ORG Sat Aug 27 13:36:46 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0EA771065670 for ; Sat, 27 Aug 2011 13:36:46 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id BD9E08FC0C for ; Sat, 27 Aug 2011 13:36:45 +0000 (UTC) Received: by gyd10 with SMTP id 10so4354446gyd.13 for ; Sat, 27 Aug 2011 06:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ssovLLOEnKOo3HahlORjxeWqGh81kcPntnbEkDqyXng=; b=Oo0gN+EvazhYsDJY+jj7iRHuk2cOHudxbTpXgJI6w+Vc8Uy98bXGvbKAksnfFdbZB8 cD17m0yfFpgHi6ZRXR/wWvUhZi6dBc71Pfq/LrRatUw43rgYBm9wGSIkglpW1bRlbazh STi3K8ttI+ag3YV3AcXlvv1EhRC6IfbMK5ZY8= MIME-Version: 1.0 Received: by 10.43.53.73 with SMTP id vp9mr2374609icb.415.1314452204869; Sat, 27 Aug 2011 06:36:44 -0700 (PDT) Received: by 10.231.42.4 with HTTP; Sat, 27 Aug 2011 06:36:44 -0700 (PDT) Received: by 10.231.42.4 with HTTP; Sat, 27 Aug 2011 06:36:44 -0700 (PDT) In-Reply-To: <867h5zm278.fsf@gmail.com> References: <20110826172328.67f707d7@cox.net> <1314402348.13483.6.camel@xenon> <867h5zt6gd.fsf@gmail.com> <867h5zm278.fsf@gmail.com> Date: Sat, 27 Aug 2011 14:36:44 +0100 Message-ID: From: Chris Rees To: Test Rat Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-ports@freebsd.org Subject: Re: Problem with nvidia-driver and "X" after upgrade X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Aug 2011 13:36:46 -0000 On 27 Aug 2011 14:08, "Test Rat" wrote: > > Chris Rees writes: > > >> >> Carmel writes: > >> >> > So, after rebuild World/Kernel and installing same and then > >> >> > rebuilding the nvidia-driver, all is well again. > >> >> > > >> >> > Now, in my not so humble opinion, there should be some sort of > >> >> > warning in the driver dialog, or at least in the port description > >> >> > that warns of this behavior. It could have save3d me several hours > >> >> > of needless searching. Hours that I will never get back. :) > [...] > > Really, the proper fix would be to make kldload give a more descriptive > > error, but IIRC this is much easier said than done... > > There are a few ports that use SRC_BASE and are *not* kernel modules, e.g. > > devel/linux_kdump > devel/linuxthreads > sysutils/lsof > > > I don't think doing more clever stuff in the port is the solution; It's not > > specific to that port. > > What about bsd.port.mk bailing out early if kernel sources are for > different version? It was in the patch you quoted but probably have not read. Hah, you're quite right, I misread. Please accept my apologies for thinking someone as smart as you could suggest such a bad idea ;) While it's not inherently terrible, it still comes under the hand-holding category that bad.port.mk is (fortunately?) lacking in. Bear on mind others are free to disagree, if you send a PR in porter will definitely give their opinion. :) Chris