From owner-freebsd-net@FreeBSD.ORG Mon Jan 14 22:47:11 2013 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 11D4DAAC for ; Mon, 14 Jan 2013 22:47:11 +0000 (UTC) (envelope-from kudzu@tenebras.com) Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com [209.85.214.169]) by mx1.freebsd.org (Postfix) with ESMTP id D4FB8FE for ; Mon, 14 Jan 2013 22:47:10 +0000 (UTC) Received: by mail-ob0-f169.google.com with SMTP id v19so4419151obq.28 for ; Mon, 14 Jan 2013 14:47:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=dARVi09cK3j8E94dQv8ZmY+ZO3fMxVSne24bX3N+FZU=; b=Ui/6GLqz+ByMSdMxvTHejtqmRvT66tyAPb71fB9bu7Ck0vL/9HlYNfKdHFDj3OXLYw NEKoI0e9yhZEvcJxP3ErTpigPwNX6+sWv0PrYtmQOEUS+y+fxLQGIyIoyDZAKHjIPvrD 17AK3a2UVESSyEJ8CqcjJb0q5fGmT0I32pFBbNrsFAuYmdCBcSc+P3j/2C++H9Q4bUjP pQqhPguXmjKDty941YLIOjVUZmHtwAk4WuGBSOp3QifeJ8YozPxde8WWELeIxADt0jwj rhw7hrFlA0T1tVfXezHc2JzaaHcZhRA7AHUHxw8JVzBc6zkzj97jjLUTiIF7gZOTkhUx Jz7g== MIME-Version: 1.0 Received: by 10.60.1.168 with SMTP id 8mr33926390oen.46.1358203629938; Mon, 14 Jan 2013 14:47:09 -0800 (PST) Received: by 10.60.119.9 with HTTP; Mon, 14 Jan 2013 14:47:09 -0800 (PST) In-Reply-To: <50F483E8.2040107@mu.org> References: <201301141550.13577.jhb@freebsd.org> <50F47BB8.9000409@mu.org> <201301141656.37175.jhb@freebsd.org> <50F483E8.2040107@mu.org> Date: Mon, 14 Jan 2013 14:47:09 -0800 Message-ID: Subject: Re: [PATCH] Don't imply TCP and UDP socket options are bitmasks From: Michael Sierchio To: Alfred Perlstein Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQl0TjrkdObkkRHL0+CkpeL6lZfMm2b5h8AsVDj8L6ZtWBUNFKiHhoj0nSDNOFJD0VugwpB4 Cc: freebsd-net@freebsd.org, John Baldwin , net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2013 22:47:11 -0000 Change "Don't imply TCP and UDP socket options are bitmasks" to "Don't infer TCP and UDP socket options are bitmasks" - M On Mon, Jan 14, 2013 at 2:17 PM, Alfred Perlstein wrote: > On 1/14/13 4:56 PM, John Baldwin wrote: >> >> On Monday, January 14, 2013 4:42:16 pm Alfred Perlstein wrote: >>> >>> Wouldn't a comment over the code suffice? >>> >>> Something like your email as a header would actually work very nicely! >>> >>> I think just using decimal would be more confusing than explicitly >>> calling it out like: >>> >>> /* begin enumerated (not bitmask) socket option specifiers */ >>> #define TCP_MAXSEG 0x02 /* set maximum segment size */ >>> #define TCP_NOPUSH 0x04 /* don't push last block of write */ >>> #define TCP_NOOPT 0x08 /* don't use TCP options */ >>> #define TCP_MD5SIG 0x10 /* use MD5 digests (RFC2385) */ >>> /* end enumerated socket option specifiers */ >> >> I have a patch I'll post next which will add a new option as '3'. I think >> that >> will make it more obvious and avoid having new options follow the old >> pattern. >> > Any objection to adding the contents of that email as a comment section? It > really would help. > > > -Alfred > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"