From owner-freebsd-drivers@FreeBSD.ORG Mon Nov 23 21:17:11 2009 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7302D106566C; Mon, 23 Nov 2009 21:17:11 +0000 (UTC) (envelope-from obrien654j@gmail.com) Received: from mail-yx0-f171.google.com (mail-yx0-f171.google.com [209.85.210.171]) by mx1.freebsd.org (Postfix) with ESMTP id BCF338FC19; Mon, 23 Nov 2009 21:17:10 +0000 (UTC) Received: by yxe1 with SMTP id 1so5236424yxe.3 for ; Mon, 23 Nov 2009 13:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=eWx1mU1POr7EqW8aItxTeHy1+wRGHlto+H+AIrbzYnk=; b=gn/InvQeQCkYEcwoqsvez//PieDYtDVd6fDBb81aMmmybWMuYkSTcjpC/lefEr1HEp 4ppJdAyfmlhGe8gt1E9WDBM0jn5ut3atikaznWt6wD3Keuyom39S7tRWO/sV+80LNsI1 S9asOKCcRsnTwJV+R+uKzG72pQb1G/0LDdnAI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=dtGCBZgbdtw/nws9vCdTKBkHfleIMPjRzClS7IMWs7IP8i5+lhxqs1/BgrU7CsmFR9 OF7OVeCca6bfO/BxdBEPBjA4KFj+sONPnOZ2MeI2N2tgrpULqlsap3U5p6YlEsNZylWW qkd1FJxGLgTxAPVaNTxMLNTX8AcSQkvemNp+s= Received: by 10.91.14.10 with SMTP id r10mr7151118agi.5.1259011024984; Mon, 23 Nov 2009 13:17:04 -0800 (PST) Received: from minifree ([74.83.26.11]) by mx.google.com with ESMTPS id 20sm1606826ywh.2.2009.11.23.13.17.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 23 Nov 2009 13:17:03 -0800 (PST) Date: Mon, 23 Nov 2009 16:17:34 -0500 From: Jeremy O'Brien To: John Baldwin Message-ID: <20091123211734.GA1207@minifree> References: <20091122175555.GA15539@minifree.wright.edu> <200911231001.51082.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200911231001.51082.jhb@freebsd.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: freebsd-drivers@freebsd.org Subject: Re: Cisco Aironet MPI350 Fix X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2009 21:17:11 -0000 On Mon, Nov 23, 2009 at 10:01:50AM -0500, John Baldwin wrote: > On Sunday 22 November 2009 12:55:55 pm Jeremy O'Brien wrote: > > Hello, > > > > I have a Cisco Aironet MPI350 PCI card in my Thinkpad X31, and on a > > fresh install of FreeBSD 8.0-RC3, the card did not work. Also, it caused > > my system to freeze up for a few seconds about once a minute as the > > driver spit out "an0: device timeout" messages so long as the interface > > was up. I researched the issue, and found the following fix already in > > dragonflybsd's tree: > > > > > http://gitweb.dragonflybsd.org/dragonfly.git/commit/7a2a04db44efafea257db883ae3eb5e4ebf2ece9 > > > > I modified the patch and applied it to FreeBSD's kernel (trivial), and > > am happy to report that my card is now working flawlessly. Could someone > > possibly review this patch and integrate it into the source tree so that > > others may benefit from it as well? > > > > The patch is based off of 8.0-RC3's code, but applies to the latest code > > as well without modification. > > Can you try this version? The IFF_DRV_OACTIVE bits don't look correct to me > so I've left them out. I also changed the driver to use bus_*() vs > bus_space_*(). > > -- > John Baldwin Tried it at home, worked great. My university's wireless is shoddy.