From owner-cvs-all@FreeBSD.ORG Thu Jan 24 11:21:55 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F92D16A419; Thu, 24 Jan 2008 11:21:55 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3413013C447; Thu, 24 Jan 2008 11:21:55 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m0OBLt9b030187; Thu, 24 Jan 2008 11:21:55 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m0OBLtRw030186; Thu, 24 Jan 2008 11:21:55 GMT (envelope-from pjd) Message-Id: <200801241121.m0OBLtRw030186@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Thu, 24 Jan 2008 11:21:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/opensolaris/kern opensolaris_kmem.c src/sys/compat/opensolaris/sys kmem.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2008 11:21:55 -0000 pjd 2008-01-24 11:21:54 UTC FreeBSD src repository Modified files: sys/compat/opensolaris/kern opensolaris_kmem.c sys/compat/opensolaris/sys kmem.h Log: Change type of kmem_used() and kmem_size() functions to uint64_t, so it doesn't overflow in arc.c in this check: if (kmem_used() > (kmem_size() * 4) / 5) return (1); With this bug ZFS almost doesn't cache. Only 32bit machines are affected that have vm.kmem_size set to values >=1GB. Reported by: David Taylor Revision Changes Path 1.3 +5 -5 src/sys/compat/opensolaris/kern/opensolaris_kmem.c 1.4 +3 -3 src/sys/compat/opensolaris/sys/kmem.h