From owner-freebsd-net@FreeBSD.ORG  Wed Sep  5 05:11:22 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B65121065673
	for <freebsd-net@freebsd.org>; Wed,  5 Sep 2012 05:11:22 +0000 (UTC)
	(envelope-from silby@silby.com)
Received: from relay01.pair.com (relay01.pair.com [209.68.5.15])
	by mx1.freebsd.org (Postfix) with SMTP id C78B88FC18
	for <freebsd-net@freebsd.org>; Wed,  5 Sep 2012 05:11:21 +0000 (UTC)
Received: (qmail 75771 invoked by uid 0); 5 Sep 2012 05:11:15 -0000
Received: from 71.195.27.106 (HELO telemachus.local) (71.195.27.106)
	by relay01.pair.com with SMTP; 5 Sep 2012 05:11:15 -0000
X-pair-Authenticated: 71.195.27.106
Message-ID: <5046DEF2.9040901@silby.com>
Date: Wed, 05 Sep 2012 00:11:14 -0500
From: Mike Silbersack <silby@silby.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8;
	rv:15.0) Gecko/20120824 Thunderbird/15.0
MIME-Version: 1.0
To: pyunyh@gmail.com
References: <5046D681.2040806@silby.com>
	<20120905205654.GA1449@michelle.cdnetworks.com>
In-Reply-To: <20120905205654.GA1449@michelle.cdnetworks.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org, davidch@freebsd.org, yongari@freebsd.org
Subject: Re: [patch] if_bxe shutdown fix
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Sep 2012 05:11:22 -0000

On 9/5/12 3:56 PM, YongHyeon PYUN wrote:
> On Tue, Sep 04, 2012 at 11:35:13PM -0500, Mike Silbersack wrote:
>> Does anyone want to review this patch before I check it in?  The change
>> has been reviewed and tested by coworkers, but not yet reviewed by any
>> other FreeBSD committers.
>>
>> http://www.silby.com/patches/if_bxe.c-safestop.patch
>>
>> This resolves an issue we saw at work where IPMI would report bus errors
>> when you rebooted a system with bxe NICs if you had not UP'd all of the
>> bxe NICs before the shutdown.
> Yeah I also have a similar patch. But I checked sc->state after
> getting a BXE_CORE_LOCK as the state is protected by the lock.
>
>> Thanks,
>>
>> Mike "Silby" Silbersack

Good catch.  How does this look?

http://www.silby.com/patches/if_bxe.c-safestop-2.patch

Mike "Silby" Silbersack