From owner-freebsd-bugs  Mon Jul  8  2:50: 8 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2762837B400
	for <freebsd-bugs@hub.freebsd.org>; Mon,  8 Jul 2002 02:50:03 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 82E9D43E5E
	for <freebsd-bugs@hub.freebsd.org>; Mon,  8 Jul 2002 02:50:02 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g689o2JU060072
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 8 Jul 2002 02:50:02 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g689o2uB060071;
	Mon, 8 Jul 2002 02:50:02 -0700 (PDT)
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2FEAB37B400
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  8 Jul 2002 02:49:19 -0700 (PDT)
Received: from www.freebsd.org (www.FreeBSD.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EB5CF43E3B
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  8 Jul 2002 02:49:18 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.4/8.12.4) with ESMTP id g689nIOT069924
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 8 Jul 2002 02:49:18 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.4/8.12.4/Submit) id g689nITC069923;
	Mon, 8 Jul 2002 02:49:18 -0700 (PDT)
Message-Id: <200207080949.g689nITC069923@www.freebsd.org>
Date: Mon, 8 Jul 2002 02:49:18 -0700 (PDT)
From: Ville-Pertti Keinonen <will@iki.fi>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: misc/40331: libalias bug causes natd crashes
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         40331
>Category:       misc
>Synopsis:       libalias bug causes natd crashes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 08 02:50:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Ville-Pertti Keinonen
>Release:        -current
>Organization:
>Environment:
>Description:
In src/lib/libalias/alias_db.c, when using NEW_IPFW, ClearFWHole doesn't check whether firewall-hole-punching is enabled and fw_clrfield may dereference a NULL-pointer.
>How-To-Repeat:

>Fix:
I worked around the problem by compiling libalias with -DNO_FW_PUNCH to get a working natd for my own use.

The correct solution is to verify either that hole-punching is enabled or that fwhole is non-negative before fw_clrfield.  There may well be other places like this.  I'd rather not take the time to check since this is probably code that is actively undergoing changes, anyhow.
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message