From owner-freebsd-ppc@freebsd.org Wed Feb 12 00:01:38 2020 Return-Path: Delivered-To: freebsd-ppc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 13B942473D9 for ; Wed, 12 Feb 2020 00:01:38 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48HKYs5kZfz4qXQ for ; Wed, 12 Feb 2020 00:01:37 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: by freefall.freebsd.org (Postfix) id B75846CA1; Wed, 12 Feb 2020 00:01:37 +0000 (UTC) Delivered-To: powerpc@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 9EF476D0C; Wed, 12 Feb 2020 00:01:37 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48HKYr5RHcz4qXH; Wed, 12 Feb 2020 00:01:36 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id BE39533E13; Tue, 11 Feb 2020 19:01:29 -0500 (EST) Received: from anthias (simmu2-75-228.utaonline.at [62.218.75.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id C80F033E0F; Tue, 11 Feb 2020 19:01:28 -0500 (EST) Date: Wed, 12 Feb 2020 01:01:25 +0100 (CET) From: Gerald Pfeifer To: Piotr Kubaj , powerpc@FreeBSD.org cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r525704 - head/math/hmat-oss In-Reply-To: <202002101323.01ADNuln021504@repo.freebsd.org> Message-ID: References: <202002101323.01ADNuln021504@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 48HKYr5RHcz4qXH X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-4.25 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:hamza.pair.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[pfeifer.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.95)[ip: (-6.68), ipnet: 209.68.0.0/18(-1.92), asn: 7859(-1.08), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[228.75.218.62.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Feb 2020 00:01:38 -0000 [ adding powerpc@ ] On Mon, 10 Feb 2020, Piotr Kubaj wrote: > Log: > math/hmat-oss: fix build on GCC architectures > > After OpenBLAS update, new GCC is required: > CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:146 (message): > Could NOT find CBLAS (missing: CBLAS_LIBRARIES) : > +.if ${CHOSEN_COMPILER_TYPE} == gcc > +USE_GCC= yes > +.endif This made me realize something bizarre: Mk/Uses/compiler.mk has .if ${_COMPILER_ARGS:Mopenmp} .if ${COMPILER_TYPE} == clang USE_GCC= yes CHOSEN_COMPILER_TYPE= gcc .endif .endif If I read this correctly, on platforms with GCC as the system compiler this means the rotten GCC 4.2 is used for something new and evolving like OpenMP? Really, OpenMP should imply USE_GCC=yes instead of even trying to rely on GCC 4.2. That would save you the effort of having to make such changes one by one and also simplify the ports tree. *And* it would align powerpc* more closely with i386/amd64 by using the same compiler for such ports. I'll be happy to prepare a patch for Mk/Uses/compiler.mk, but we'd need you (and/or other powerpc* folks) to give it a try and adjust things if necessary. Would you like to? Gerald