Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 May 2004 13:31:42 -0700 (PDT)
From:      Thierry Thomas <thierry@FreeBSD.org>
To:        tiamat@comset.net, thierry@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Subject:   Re: ports/62411: New port: graphics/smoke Vector graphics OpenGL renderer
Message-ID:  <200405252031.i4PKVgvN061064@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
Synopsis: New port: graphics/smoke Vector graphics OpenGL renderer

State-Changed-From-To: open->analyzed
State-Changed-By: thierry
State-Changed-When: Tue May 25 13:26:12 PDT 2004
State-Changed-Why: 

The submitted port breaks the INDEX and does not compile with
the new freetype.

It is clean with the following patch:

--- smoke.diff begins here ---
diff -urN graphics/smoke.orig/Makefile graphics/smoke/Makefile
--- graphics/smoke.orig/Makefile	Mon May 24 21:47:13 2004
+++ graphics/smoke/Makefile	Mon May 24 22:19:01 2004
@@ -24,15 +24,22 @@
 
 WRKSRC=		${WRKDIR}/${PORTNAME}
 
-.include <bsd.port.pre.mk>
-
 FREETYPE_CONFIG?=	${LOCALBASE}/bin/freetype-config
 SDL_CONFIG?=		${LOCALBASE}/bin/sdl11-config
-FREETYPE_INCLUDEPATH!=	${FREETYPE_CONFIG} --cflags | ${SED} -e 's|-I||g'
-SDL_INCLUDEPATH!=	${SDL_CONFIG} --cflags | ${SED} -e 's|-I||g; s|-D[[:graph:]]*||g'
 TMAKE?=			${LOCALBASE}/bin/tmake
 TMAKEPATH?=		${LOCALBASE}/share/tmake/freebsd-g++
 
+PORTSDOC=	README
+
+.include <bsd.port.pre.mk>
+
+.if exists(${FREETYPE_CONFIG})
+FREETYPE_INCLUDEPATH!=	${FREETYPE_CONFIG} --cflags | ${SED} -e 's|-I||g'
+.endif
+.if exists(${SDL_CONFIG})
+SDL_INCLUDEPATH!=	${SDL_CONFIG} --cflags | ${SED} -e 's|-I||g; s|-D[[:graph:]]*||g'
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|%%FREETYPE_CONFIG%%|${FREETYPE_CONFIG}|g; \
 			      s|%%SDL_CONFIG%%|${SDL_CONFIG}|g; \
@@ -47,14 +54,12 @@
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/smoke ${PREFIX}/bin
-
 	@${MKDIR} ${EXAMPLESDIR}
 	@${MKDIR} ${EXAMPLESDIR}/tests
 	${INSTALL_DATA} ${WRKSRC}/tests/tiger.* ${EXAMPLESDIR}/tests
-
 .ifndef (NOPORTDOCS)
 	@${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}
+	${INSTALL_DATA} ${PORTSDOC:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.post.mk>
diff -urN graphics/smoke.orig/distinfo graphics/smoke/distinfo
--- graphics/smoke.orig/distinfo	Mon May 24 21:47:13 2004
+++ graphics/smoke/distinfo	Mon May 24 22:04:49 2004
@@ -1 +1,2 @@
 MD5 (smoke-0.5.1.tar.bz2) = c0e46c652a5fcccd7b511fbb056a1fae
+SIZE (smoke-0.5.1.tar.bz2) = 192646
diff -urN graphics/smoke.orig/files/patch-src_store.h graphics/smoke/files/patch-src_store.h
--- graphics/smoke.orig/files/patch-src_store.h	Thu Jan  1 01:00:00 1970
+++ graphics/smoke/files/patch-src_store.h	Mon May 24 22:10:37 2004
@@ -0,0 +1,13 @@
+--- src/store.h.orig	Sat May 17 15:34:24 2003
++++ src/store.h	Mon May 24 22:08:54 2004
+@@ -32,8 +32,8 @@
+ 
+ #include <string>
+ #include <map>
+-#include <freetype/freetype.h>
+-
++#include <ft2build.h>
++#include FT_FREETYPE_H
+ 
+ 
+ class Store
diff -urN graphics/smoke.orig/pkg-plist graphics/smoke/pkg-plist
--- graphics/smoke.orig/pkg-plist	Mon May 24 21:47:13 2004
+++ graphics/smoke/pkg-plist	Mon May 24 22:16:25 2004
@@ -1,7 +1,5 @@
 bin/smoke
-%%PORTDOCS%%%%DOCSDIR%%/README
 %%EXAMPLESDIR%%/tests/tiger.smoke
 %%EXAMPLESDIR%%/tests/tiger.svg
 @dirrm %%EXAMPLESDIR%%/tests
 @dirrm %%EXAMPLESDIR%%
-%%PORTDOCS%%@dirrm %%DOCSDIR%%
--- smoke.diff ends here ---

Unfortunately, I cannot test it, and get the following message:

Program started.
Initialised SDL.
Setting SDL attributes...
Couldn't set GL mode: X11 driver not configured with OpenGL


http://www.freebsd.org/cgi/query-pr.cgi?pr=62411



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200405252031.i4PKVgvN061064>