From nobody Fri Feb 17 22:52:06 2023
X-Original-To: freebsd-security@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PJRs42qMKz3rsjT
	for <freebsd-security@mlmmj.nyi.freebsd.org>; Fri, 17 Feb 2023 22:52:08 +0000 (UTC)
	(envelope-from list_freebsd@bluerosetech.com)
Received: from echo.brtsvcs.net (echo.brtsvcs.net [208.111.40.118])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4PJRs40hZyz4PDV
	for <freebsd-security@freebsd.org>; Fri, 17 Feb 2023 22:52:08 +0000 (UTC)
	(envelope-from list_freebsd@bluerosetech.com)
Authentication-Results: mx1.freebsd.org;
	none
Received: from chombo.houseloki.net (65-100-43-2.dia.static.qwest.net [65.100.43.2])
	by echo.brtsvcs.net (Postfix) with ESMTPS id 5BC7D38D00;
	Fri, 17 Feb 2023 22:52:05 +0000 (UTC)
Received: from [10.26.25.100] (ivy.pas.ds.pilgrimaccounting.com [10.26.25.100])
	by chombo.houseloki.net (Postfix) with ESMTPSA id F320314211;
	Fri, 17 Feb 2023 14:52:04 -0800 (PST)
Subject: Re: FreeBSD Security Advisory FreeBSD-SA-23:01.geli
To: grarpamp <grarpamp@gmail.com>, freebsd-security@freebsd.org
References: <20230208190833.1DF6F8824@freefall.freebsd.org>
 <d9a388ec-4e29-1423-e168-3d05c310e099@bluerosetech.com>
 <CAGOYWV_26qGLPO+ZNL6N8p57JhguU=heYQ3ejQqqvFJzYXwv-A@mail.gmail.com>
 <86f2e6b1-aeef-2472-eeb2-42bee64ac812@bluerosetech.com>
 <CAD2Ti2-K7LeWWSRas_G3pB56V5qApn7cPr37hQDb+r-wCpm6MA@mail.gmail.com>
From: Mel Pilgrim <list_freebsd@bluerosetech.com>
Message-ID: <88b49b58-d6af-0ea1-dd74-b44c5842c2fc@bluerosetech.com>
Date: Fri, 17 Feb 2023 14:52:06 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
List-Id: Security issues <freebsd-security.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-security
List-Help: <mailto:freebsd-security+help@freebsd.org>
List-Post: <mailto:freebsd-security@freebsd.org>
List-Subscribe: <mailto:freebsd-security+subscribe@freebsd.org>
List-Unsubscribe: <mailto:freebsd-security+unsubscribe@freebsd.org>
Sender: owner-freebsd-security@freebsd.org
X-BeenThere: freebsd-security@freebsd.org
MIME-Version: 1.0
In-Reply-To: <CAD2Ti2-K7LeWWSRas_G3pB56V5qApn7cPr37hQDb+r-wCpm6MA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4PJRs40hZyz4PDV
X-Spamd-Bar: ----
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:36236, ipnet:208.111.40.0/24, country:US]
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-ThisMailContainsUnwantedMimeParts: N

On 2023-02-16 17:27, grarpamp wrote:
> On 2/15/23, Mel Pilgrim <list_freebsd@bluerosetech.com> wrote:
>> # echo -n | geli attach -C -p -k - gpt/zdata15
>> geli: Wrong key for gpt/zdata15.
>> geli: There was an error with at least one provider.
> 
> That test failed so the "empty" or "NULL" key (aka "echo -n")
> is not the key. These should not work either
> 
> printf '' | geli
> printf '\000'
> printf '\n'
> printf ' '
> printf 'notthekey'
> 
> and only
> 
> cat /path/to/your/keyfile | geli
> 
> should work.

Thank you for the clarification.  I tested all of my geli devices and 
indeed anything I try other than the correct keyfile for that device 
produces that error so I'm assuming that means I don't need to re-crypt 
things.