From owner-cvs-all@FreeBSD.ORG  Sun Feb 10 14:34:32 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3318B16A420;
	Sun, 10 Feb 2008 14:34:32 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id E610113C448;
	Sun, 10 Feb 2008 14:34:31 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id A94A046DF8;
	Sun, 10 Feb 2008 09:34:30 -0500 (EST)
Date: Sun, 10 Feb 2008 14:34:30 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Attilio Rao <attilio@freebsd.org>
In-Reply-To: <3bbf2fe10802100449r1b673bbfl3e41a419b08c0@mail.gmail.com>
Message-ID: <20080210143313.W90254@fledge.watson.org>
References: <200802092137.m19Lbsiu098036@repoman.freebsd.org> 
	<20080210113949.GN57756@deviant.kiev.zoral.com.ua>
	<20080210120359.A97821@fledge.watson.org>
	<3bbf2fe10802100449r1b673bbfl3e41a419b08c0@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Kostik Belousov <kostikbel@gmail.com>, cvs-src@freebsd.org,
	src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/sys lockmgr.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Feb 2008 14:34:32 -0000


On Sun, 10 Feb 2008, Attilio Rao wrote:

>> > I think this shall be MFCed to RELENG_7 and RELENG_7_0.
>>
>> ... once it no longer breaks the tinderbox?
>>
>> BTW, at this point 7.0 is basically closed to any further changes.  Anyone 
>> planning on getting things in to 7.x needs to be thinking about either 
>> errata notices (for really critical things) and 7.1.
>
> Buh! I'm very sorry for this. Really, this needed to be better croaked. It 
> needs to include sys/lock.h for any lockmgr.h consumer (making lock.h a 
> pre-requirement in lockmgr usage). This is going to be a little bit of work.
>
> For the moment I will revert this change, doing a better stub later, once 
> other details about lockmgr are refined.

Or temporarily nested include lock.h from lockmgr.h.  I'm pretty sure that all 
consumers of struct lock pretty much include _lock.h, so if there's a 
widespread dependency you could also move whatever the definitions are to 
_lock.h.

Robert N M Watson
Computer Laboratory
University of Cambridge