Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Jun 2020 17:47:01 +0000 (UTC)
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r362786 - head/sys/compat/linux
Message-ID:  <202006291747.05THl163091903@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kevans
Date: Mon Jun 29 17:47:00 2020
New Revision: 362786
URL: https://svnweb.freebsd.org/changeset/base/362786

Log:
  linux: reposition the comment for bsd_to_linux_bits/linux_to_bsd_bits
  
  rpokala notes that splitting the definitions like this is kind of silly,
  since the comment applies to both.  Move the comment up (or the definition
  down, depending on your perspective on life) accordingly.
  
  Reported by:	rpokala

Modified:
  head/sys/compat/linux/linux.h

Modified: head/sys/compat/linux/linux.h
==============================================================================
--- head/sys/compat/linux/linux.h	Mon Jun 29 17:19:08 2020	(r362785)
+++ head/sys/compat/linux/linux.h	Mon Jun 29 17:47:00 2020	(r362786)
@@ -165,9 +165,6 @@ int bsd_to_linux_bits_(int value, struct bsd_to_linux_
 int linux_to_bsd_bits_(int value, struct bsd_to_linux_bitmap *bitmap,
     size_t mapcnt, int no_value);
 
-#define	bsd_to_linux_bits(_val, _bmap, _noval) \
-    bsd_to_linux_bits_((_val), (_bmap), nitems((_bmap)), (_noval))
-
 /*
  * These functions are used for simplification of BSD <-> Linux bit conversions.
  * Given `value`, a bit field, these functions will walk the given bitmap table
@@ -176,6 +173,8 @@ int linux_to_bsd_bits_(int value, struct bsd_to_linux_
  * represented with the bit values appropriate for the target platform.
  * Otherwise, the value supplied as `no_value` is returned.
  */
+#define	bsd_to_linux_bits(_val, _bmap, _noval) \
+    bsd_to_linux_bits_((_val), (_bmap), nitems((_bmap)), (_noval))
 #define	linux_to_bsd_bits(_val, _bmap, _noval) \
     linux_to_bsd_bits_((_val), (_bmap), nitems((_bmap)), (_noval))
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202006291747.05THl163091903>