From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Aug 30 17:00:19 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AC0D21065675 for ; Thu, 30 Aug 2012 17:00:19 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6B50B8FC20 for ; Thu, 30 Aug 2012 17:00:19 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q7UH0JED002647 for ; Thu, 30 Aug 2012 17:00:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q7UH0JkA002646; Thu, 30 Aug 2012 17:00:19 GMT (envelope-from gnats) Resent-Date: Thu, 30 Aug 2012 17:00:19 GMT Resent-Message-Id: <201208301700.q7UH0JkA002646@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Christopher McCoy Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3EAED1065670 for ; Thu, 30 Aug 2012 16:53:48 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 2951E8FC20 for ; Thu, 30 Aug 2012 16:53:48 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7UGrlnJ067640 for ; Thu, 30 Aug 2012 16:53:47 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q7UGrlI3067639; Thu, 30 Aug 2012 16:53:47 GMT (envelope-from nobody) Message-Id: <201208301653.q7UGrlI3067639@red.freebsd.org> Date: Thu, 30 Aug 2012 16:53:47 GMT From: Christopher McCoy To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/171188: puppet shell_config example no longer works due to puppet bug #15080 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2012 17:00:19 -0000 >Number: 171188 >Category: ports >Synopsis: puppet shell_config example no longer works due to puppet bug #15080 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Aug 30 17:00:19 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Christopher McCoy >Release: 9.0-RELEASE >Organization: Wayfair LLC >Environment: FreeBSD packages.wayfair.com 9.0-RELEASE FreeBSD 9.0-RELEASE #4: Fri Feb 17 12:57:26 EST 2012 root@packages.wayfair.com:/usr/obj/usr/src/sys/GENERIC amd64 >Description: sysutils/puppet 2.7.19 Puppet provides an example which makes modifying /etc/sysctl.conf /etc/rc.conf and a few other key values files much easier. This example is here: http://projects.puppetlabs.com/projects/1/wiki/Puppet_Free_Bsd This no longer works in certain cases due to this bug: http://projects.puppetlabs.com/issues/15080 I've essentially just made this patch more freebsd/portstree friendly. >How-To-Repeat: >Fix: Patch attached with submission follows: --- lib/puppet/provider/exec.rb.orig 2012-08-21 17:41:17.000000000 -0400 +++ lib/puppet/provider/exec.rb 2012-08-30 12:31:32.000000000 -0400 @@ -66,11 +66,9 @@ end def extractexe(command) - if command.is_a? Array - command.first - elsif match = /^"([^"]+)"|^'([^']+)'/.match(command) - # extract whichever of the two sides matched the content. - match[1] or match[2] + # easy case: command was quoted + if command =~ /^"([^"]+)"/ + $1 else command.split(/ /)[0] end >Release-Note: >Audit-Trail: >Unformatted: