From owner-freebsd-bugs@FreeBSD.ORG Thu Mar 21 16:58:58 2013 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 4DCABFC8; Thu, 21 Mar 2013 16:58:58 +0000 (UTC) (envelope-from hiren.panchasara@gmail.com) Received: from mail-ea0-x22c.google.com (mail-ea0-x22c.google.com [IPv6:2a00:1450:4013:c01::22c]) by mx1.freebsd.org (Postfix) with ESMTP id BFE60B68; Thu, 21 Mar 2013 16:58:57 +0000 (UTC) Received: by mail-ea0-f172.google.com with SMTP id d10so1023419eaj.3 for ; Thu, 21 Mar 2013 09:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=mCUieoa4WDfRMtSTE0JADQwwc0ydRdu1F45rWtomk38=; b=oQcLdBBjzkmUZFNi1iIhYwYkIdtRDn6OwuaTAtwnkNEvqg0/z1dP3AlUCOMak1jth5 6ib+zELd2La6CfoejSWXm+A4Yg9Rij520k9n0baCZI0Q0BhT8JHhGRTFBRcNbZHEP1B1 gjEznNFhYakxcANG9e/0M91L0jmzKrxVnpDcLn68dLXdDhQeFGP4RNNcaJ6BZPq+CDnA HHzwoPTrvUi4irjVIHuZipnzK+4uEyBDtE1Il8ROsUrp1pVu6MMUrRCAbiu70FoNRdCf KVRtx4geuxgYJ0qocCZQt4tdjvEdi3+F9Mogb8RNQSW+ZTT7ck88SUwPT+29TetXu1MH Y+Zw== MIME-Version: 1.0 X-Received: by 10.14.216.198 with SMTP id g46mr83853441eep.30.1363885136952; Thu, 21 Mar 2013 09:58:56 -0700 (PDT) Received: by 10.14.133.204 with HTTP; Thu, 21 Mar 2013 09:58:56 -0700 (PDT) In-Reply-To: <201303202010.r2KKA0ut076559@freefall.freebsd.org> References: <201303202006.r2KK632x071282@red.freebsd.org> <201303202010.r2KKA0ut076559@freefall.freebsd.org> Date: Thu, 21 Mar 2013 09:58:56 -0700 Message-ID: Subject: Re: kern/177155: [patch] Fixing clang warnings at /sys/dev/safe From: hiren panchasara To: FreeBSD-gnats-submit@freebsd.org, freebsd-bugs@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2013 16:58:58 -0000 On Wed, Mar 20, 2013 at 1:10 PM, wrote: > Thank you very much for your problem report. > It has the internal identification `kern/177155'. > The individual assigned to look at your > report is: freebsd-bugs. > > You can access the state of your problem report at any time > via this link: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=177155 > >>Category: kern >>Responsible: freebsd-bugs >>Synopsis: [patch] Fixing clang warnings at /sys/dev/safe >>Arrival-Date: Wed Mar 20 20:10:00 UTC 2013 Taking a closer look, more correct fix looks like this: Index: sys/dev/safe/safe.c =================================================================== --- sys/dev/safe/safe.c (revision 248555) +++ sys/dev/safe/safe.c (working copy) @@ -122,7 +122,7 @@ static void safe_intr(void *); static void safe_callback(struct safe_softc *, struct safe_ringentry *); static void safe_feed(struct safe_softc *, struct safe_ringentry *); -static void safe_mcopy(struct mbuf *, struct mbuf *, u_int); +static void safe_mcopy(struct mbuf *, struct mbuf *, int); #ifndef SAFE_NO_RNG static void safe_rng_init(struct safe_softc *); static void safe_rng(void *); @@ -1598,10 +1598,11 @@ * Copy all data past offset from srcm to dstm. */ static void -safe_mcopy(struct mbuf *srcm, struct mbuf *dstm, u_int offset) +safe_mcopy(struct mbuf *srcm, struct mbuf *dstm, int offset) { - u_int j, dlen, slen; + u_int dlen, slen; caddr_t dptr, sptr; + int j; /* * Advance src and dst to offset. Reason being (as per my understanding): safe_mcopy() is being called from only one place: safe_process() where 3rd arg to safe_mcopy() oplen is of type int. Thanks, Hiren