From owner-freebsd-bugs@FreeBSD.ORG Fri Nov 5 16:30:10 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A37731065679 for ; Fri, 5 Nov 2010 16:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 651C38FC1A for ; Fri, 5 Nov 2010 16:30:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oA5GUASn046893 for ; Fri, 5 Nov 2010 16:30:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oA5GUAHP046892; Fri, 5 Nov 2010 16:30:10 GMT (envelope-from gnats) Resent-Date: Fri, 5 Nov 2010 16:30:10 GMT Resent-Message-Id: <201011051630.oA5GUAHP046892@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kris Moore Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8BEF41065672 for ; Fri, 5 Nov 2010 16:28:19 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 5F6838FC17 for ; Fri, 5 Nov 2010 16:28:19 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id oA5GSJiV079859 for ; Fri, 5 Nov 2010 16:28:19 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id oA5GSJuF079858; Fri, 5 Nov 2010 16:28:19 GMT (envelope-from nobody) Message-Id: <201011051628.oA5GSJuF079858@www.freebsd.org> Date: Fri, 5 Nov 2010 16:28:19 GMT From: Kris Moore To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/151967: src: usr.sbin/pc-sysinstall - Add support 4k partition alignment X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2010 16:30:10 -0000 >Number: 151967 >Category: misc >Synopsis: src: usr.sbin/pc-sysinstall - Add support 4k partition alignment >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Nov 05 16:30:09 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Kris Moore >Release: 9.0-Current >Organization: PC-BSD / iXsystems >Environment: 9.0-Current >Description: After talking to pjd@, jpaetzel@ and a few others at MeetBSD, the fix to getting proper alignment on 4K drives seems to be changing our starting block to "64" when doing a full-disk installation or creating the first partition. The attached patch fixes this. >How-To-Repeat: >Fix: Attached patch fixes the issue in pc-sysinstall Patch attached with submission follows: diff -ruN src.o/usr.sbin/pc-sysinstall/backend/functions-disk.sh src/usr.sbin/pc-sysinstall/backend/functions-disk.sh --- src.o/usr.sbin/pc-sysinstall/backend/functions-disk.sh 2010-11-05 12:05:57.066860900 -0400 +++ src/usr.sbin/pc-sysinstall/backend/functions-disk.sh 2010-11-05 12:11:43.416538580 -0400 @@ -562,6 +562,8 @@ init_gpt_full_disk() { _intDISK=$1 + + startblock="64" # Set our sysctl so we can overwrite any geom using drives sysctl kern.geom.debugflags=16 >>${LOGOUT} 2>>${LOGOUT} @@ -580,7 +582,7 @@ echo_log "Running gpart on ${_intDISK}" rc_halt "gpart create -s GPT ${_intDISK}" - rc_halt "gpart add -b 34 -s 128 -t freebsd-boot ${_intDISK}" + rc_halt "gpart add -b ${startblock} -s 128 -t freebsd-boot ${_intDISK}" echo_log "Stamping boot sector on ${_intDISK}" rc_halt "gpart bootcode -b /boot/pmbr ${_intDISK}" @@ -593,7 +595,7 @@ _intDISK=$1 _intBOOT=$2 - startblock="63" + startblock="64" # Set our sysctl so we can overwrite any geom using drives sysctl kern.geom.debugflags=16 >>${LOGOUT} 2>>${LOGOUT} @@ -763,7 +765,7 @@ # Lets get the starting block first if [ "${slicenum}" = "1" ] then - startblock="63" + startblock="64" else # Lets figure out where the prior slice ends checkslice="`expr ${slicenum} - 1`" diff -ruN src.o/usr.sbin/pc-sysinstall/backend-partmanager/create-part.sh src/usr.sbin/pc-sysinstall/backend-partmanager/create-part.sh --- src.o/usr.sbin/pc-sysinstall/backend-partmanager/create-part.sh 2010-11-05 12:05:56.876842879 -0400 +++ src/usr.sbin/pc-sysinstall/backend-partmanager/create-part.sh 2010-11-05 12:25:50.192031927 -0400 @@ -69,7 +69,7 @@ # Lets get the starting block if [ "${SLICENUM}" = "1" ] ; then - STARTBLOCK="63" + STARTBLOCK="64" else # Lets figure out where the prior slice ends checkslice="`expr ${SLICENUM} - 1`" >Release-Note: >Audit-Trail: >Unformatted: