From owner-freebsd-fs@FreeBSD.ORG  Mon Feb  6 17:40:22 2012
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2695B106566C
	for <freebsd-fs@FreeBSD.org>; Mon,  6 Feb 2012 17:40:22 +0000 (UTC)
	(envelope-from jh@FreeBSD.org)
Received: from gw02.mail.saunalahti.fi (gw02.mail.saunalahti.fi
	[195.197.172.116])
	by mx1.freebsd.org (Postfix) with ESMTP id CEF428FC16
	for <freebsd-fs@FreeBSD.org>; Mon,  6 Feb 2012 17:40:21 +0000 (UTC)
Received: from a91-153-116-96.elisa-laajakaista.fi
	(a91-153-116-96.elisa-laajakaista.fi [91.153.116.96])
	by gw02.mail.saunalahti.fi (Postfix) with SMTP id 0496D139814;
	Mon,  6 Feb 2012 19:40:17 +0200 (EET)
Date: Mon, 6 Feb 2012 19:40:16 +0200
From: Jaakko Heinonen <jh@FreeBSD.org>
To: Martin Matuska <mm@FreeBSD.org>
Message-ID: <20120206174016.GA2270@a91-153-116-96.elisa-laajakaista.fi>
References: <4F2F9CB9.3040000@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F2F9CB9.3040000@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-fs@FreeBSD.org
Subject: Re: [CFR][DEVFS] Add "ruleset" mount option
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Feb 2012 17:40:22 -0000

On 2012-02-06, Martin Matuska wrote:
> The attached patch adds a "ruleset" mount option to devfs mounts.

> +	if (mp->mnt_optnew != NULL &&
> +	    vfs_getopt(mp->mnt_optnew, "ruleset", NULL, NULL) == 0) {
> +		if (vfs_scanopt(mp->mnt_optnew, "ruleset", "%d",
> +		    &rsnum) != 1) {
> +			vfs_mount_error(mp, "%s",
> +			    "invalid ruleset specification");
> +			return (EINVAL);
> +		}
> +	}

The "ruleset" mount option will persist after the devfs_mount() call. It
will get out of sync if the ruleset is later changed with the devfs
command.

devfs_mount() seems to miss a vfs_filteropt(9) call.

-- 
Jaakko