From owner-svn-ports-all@freebsd.org  Sun Jul  5 08:44:19 2020
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2BE8336583A;
 Sun,  5 Jul 2020 08:44:19 +0000 (UTC)
 (envelope-from zeising@freebsd.org)
Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4B02LV5r1Gz4ft7;
 Sun,  5 Jul 2020 08:44:18 +0000 (UTC)
 (envelope-from zeising@freebsd.org)
Received: from cid.daemonic.se (localhost [IPv6:::1])
 by mail.daemonic.se (Postfix) with ESMTP id 4B02LK6NBgz3mQC;
 Sun,  5 Jul 2020 08:44:09 +0000 (UTC)
X-Virus-Scanned: amavisd-new at daemonic.se
Received: from mail.daemonic.se ([127.0.0.1]) (using TLS with cipher
 ECDHE-RSA-AES128-GCM-SHA256)
 by cid.daemonic.se (mailscanner.daemonic.se [127.0.0.1]) (amavisd-new,
 port 10587)
 with ESMTPS id zw4llHB2qdL0; Sun,  5 Jul 2020 08:44:09 +0000 (UTC)
Received: from garnet.daemonic.se (unknown
 [IPv6:2001:470:dca9:201:253a:8fef:7002:6a8a])
 by mail.daemonic.se (Postfix) with ESMTPSA id 4B02LK1RH0z3mMv;
 Sun,  5 Jul 2020 08:44:09 +0000 (UTC)
Subject: Re: svn commit: r541237 - head/lang/ghc
To: Alexey Dokuchaev <danfe@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
References: <202007042137.064LbJff092501@repo.freebsd.org>
 <20200705044642.GA60961@FreeBSD.org>
From: Niclas Zeising <zeising@freebsd.org>
Message-ID: <6fa709cb-9a1a-06a0-2984-cc4f8b382556@freebsd.org>
Date: Sun, 5 Jul 2020 10:44:07 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200705044642.GA60961@FreeBSD.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4B02LV5r1Gz4ft7
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[];
 ASN(0.00)[asn:36236, ipnet:2607:f740:d::/48, country:US]
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Jul 2020 08:44:19 -0000

On 2020-07-05 06:46, Alexey Dokuchaev wrote:
> On Sat, Jul 04, 2020 at 09:37:19PM +0000, Niclas Zeising wrote:
>> New Revision: 541237
>> URL: https://svnweb.freebsd.org/changeset/ports/541237
>>
>> Log:
>>    Don't hardcode the libffi shared library version in lang/ghc makefile.
>>    This fixes the build after devel/libffi was updated.
>>    This was missed in r541232
>>
>> ...
>> @@ -56,7 +56,7 @@ DYNAMIC_CONFIGURE_WITH=	system-libffi \
>>   			ffi-includes=${LOCALBASE}/include \
>>   			ffi-libraries=${LOCALBASE}/lib
>>   # The version number is needed as lang/gcc installs a different version
>> -DYNAMIC_LIB_DEPENDS=	libffi.so.6:devel/libffi
>> +DYNAMIC_LIB_DEPENDS=	libffi.so:devel/libffi
> 
> So what about the comment above that line you've changed?
> 
> ./danfe
> 

The comment is a left over that I forgot to remove.  It is no longer 
true, gcc does not ship a libffi.so of its own.  I have removed the comment.
Regards
-- 
Niclas Zeising