From owner-svn-src-head@freebsd.org Fri Feb 17 10:24:12 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3EF8CE2B82; Fri, 17 Feb 2017 10:24:12 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 402281A2D; Fri, 17 Feb 2017 10:24:12 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm0-x230.google.com with SMTP id 196so8662829wmm.1; Fri, 17 Feb 2017 02:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=yhLagh7+QKCScF5J6G9I2n+oQ4T9tLkkPC+toqnb9rE=; b=OMUUWPsvKO/xLOpfkK7i17/FZfEtfmz7reRNqjYRB1S9kCtqd4WznrLmK+uLfZkJdk aDE6JsZ3+xaHmZByDpiiOZrnvZpMw9Uk+0R69UjEdz5EsHHV+/gelnR7VRBB5dz6UQSC 4Ck1oylcY/tnqVbkMPL11Xy7fmth8OZp57rYlWA+Itpcwpa9VuHSNmCuaFkV22SiAH53 LXMaHyXkPFRKwod/MmN1VGIuirZ3dE//5mI3DC1H/4K5bwcI304wGJFsEC9KbyqiyEE8 wFvchutkJ5XBIccXlTLi5ux9R/9i8TBwUD1ZndvQhkaqRwctpoZlOdJTDwefBUR64adx uLog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=yhLagh7+QKCScF5J6G9I2n+oQ4T9tLkkPC+toqnb9rE=; b=LUeOvSAW7NM0T+ymXTlNDaYTBW5w3nOWnc0XHsto3lUHsDvZk3TKNYcJPn/Tr4B5Rj xEHb3+udztkQkHMTakS6aDHmcW9ArndTEOrv06KMLm5U2IYWSDT3CVat+hBk+qqaiUso 0uFJwQajP1xUbYMNOUG91akNodoZ4kCAVlOIhwjaGjP+p5ilUTDTtaRJ+Nuj08EdiJpM SqIXAE8OW4+bZGOUHwWWQo3ey8XKU3Mg0ILxgo4z7Zx0bhMmzOBSCC5apG8zhWc5KZkO v9muzVTiXtXkHWt2HJ+X6zmaeZencWqhP2JqJXsvhDYUwxmtljZ6xSTvusZHFU/+BtiW K/9Q== X-Gm-Message-State: AMke39l+KduH3xatLs7CsiIHUi420oLQ9GT7D7Djy0EvO2/taBWmGsgdI5nLM4YMfEduRQ== X-Received: by 10.28.236.93 with SMTP id k90mr1409754wmh.40.1487327050660; Fri, 17 Feb 2017 02:24:10 -0800 (PST) Received: from brick (global-5-142.nat-2.net.cam.ac.uk. [131.111.5.142]) by smtp.gmail.com with ESMTPSA id q1sm1150298wmd.6.2017.02.17.02.24.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Feb 2017 02:24:10 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Fri, 17 Feb 2017 10:24:08 +0000 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= To: Alexander Motin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313854 - head/sys/cam/ctl Message-ID: <20170217102408.GA74901@brick> Mail-Followup-To: Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201702170522.v1H5MwGK027647@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201702170522.v1H5MwGK027647@repo.freebsd.org> User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 10:24:12 -0000 On 0217T0522, Alexander Motin wrote: > Author: mav > Date: Fri Feb 17 05:22:58 2017 > New Revision: 313854 > URL: https://svnweb.freebsd.org/changeset/base/313854 > > Log: > Change the way MaxCmdSN is used. > > Before this change MaxCmdSN was reported as CmdSN + delta, that made it > limit number of requests in transmission from the initiator to target, > that was pretty useless. After this change MaxCmdSN limits number of > requests queued to CTL, i.e. maximal queue depth for the initiator. > The default limit is 256 outstanding requests per initiator at a time. > > This code uses existing cs_outstanding_ctl_pdus counter to track queue > depth. It's semantics doen't perfectly match, but close enough to not > add another counter. Just don't set the maxtags below 2. I like the change in principle, but I don't like the gratuitous change of sysctl name. It will break people's configs. Could you rename it back? Thanks!