From owner-freebsd-commit Tue Oct 31 00:32:35 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA02157 for freebsd-commit-outgoing; Tue, 31 Oct 1995 00:32:35 -0800 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA02141 for cvs-all-outgoing; Tue, 31 Oct 1995 00:32:32 -0800 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA02129 for cvs-libexec-outgoing; Tue, 31 Oct 1995 00:32:30 -0800 Received: from jhome.DIALix.COM (root@jhome.DIALix.COM [192.203.228.69]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id AAA01954 ; Tue, 31 Oct 1995 00:30:41 -0800 Received: (from peter@localhost) by jhome.DIALix.COM (8.6.12/8.6.9) id QAA22655; Tue, 31 Oct 1995 16:30:28 +0800 Date: Tue, 31 Oct 1995 16:30:27 +0800 (WST) From: Peter Wemm To: "Andrey A. Chernov" cc: CVS-commiters@freefall.freebsd.org, cvs-libexec@freefall.freebsd.org Subject: Re: cvs commit: src/libexec/mail.local Makefile mail.local.c In-Reply-To: <199510310822.AAA00415@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-commit@FreeBSD.org Precedence: bulk On Tue, 31 Oct 1995, Andrey A. Chernov wrote: > ache 95/10/31 00:22:14 > > Modified: libexec/mail.local Makefile mail.local.c > Log: > Put fsync under #ifdef EXTRA_SANITY and turn it off by default. > fsync here cause real disk trashing when large UUCP mail chanks > parsed. I dont mean to upset Andrey, but IMHO, this is a FUNDAMENTAL sanity requirement. IMHO, incoming email is *precious*, especially on a commercial system. Andrey, I respectfully request that you change it from #ifdef EXTRA_SANITY fsync().. #endif to #ifndef DONT_FSYNC fsync() #endif And the same for Taylor-UUCP 1.06, and sendmail(?) in case you were thinking about doing those too. IMHO, this is bad karma, because we've committed to accepting and delivering the mail. -Peter