From owner-cvs-all@FreeBSD.ORG Tue May 2 03:37:22 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.ORG Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64AF416A402; Tue, 2 May 2006 03:37:22 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id C072343D46; Tue, 2 May 2006 03:37:21 +0000 (GMT) (envelope-from sobomax@sippysoft.com) Received: from sippysoft.com (localhost.360sip.com [127.0.0.1]) by sippysoft.com (8.13.4/8.13.4) with ESMTP id k423b4dd032669 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 1 May 2006 20:37:04 -0700 (PDT) (envelope-from sobomax@sippysoft.com) Received: (from sobomax@localhost) by sippysoft.com (8.13.4/8.13.4/Submit) id k423axnt032660; Mon, 1 May 2006 20:36:59 -0700 (PDT) (envelope-from sobomax) Date: Mon, 1 May 2006 20:36:59 -0700 From: Maxim Sobolev To: Scott Long Message-ID: <20060502033659.GA32417@gk.360sip.com> References: <200605010015.k410FDef095624@repoman.freebsd.org> <4456B86D.2080207@FreeBSD.org> <4456BC5A.2090308@samsco.org> <4456C049.2020805@errno.com> <4456C244.8020509@samsco.org> <4456C28C.502@errno.com> <4456C4C5.7030602@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4456C4C5.7030602@samsco.org> User-Agent: Mutt/1.4.2.1i Cc: Sam Leffler , src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/share/man/man4 Makefile rr232x.4 src/sys/dev/rr232x LICENSE README amd64-elf.rr232x_lib.o.uu array.h him.h himfuncs.h hptintf.h i386-elf.rr232x_lib.o.uu ldm.h list.h os_bsd.c os_bsd.h osm.h osm_bsd.c rr232x_config.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2006 03:37:22 -0000 IMHO it is misleading, since FreeBSD users get used to the fact that the driver only announces itself if actual hardware is present in the system. With number of supported devices in GENERIC growing up dmesg will eventually turn into mess if each device driver will announce itself unconditionally. At the very least, please put those printf's under if (bootverbose). -Maxim On Mon, May 01, 2006 at 08:32:37PM -0600, Scott Long wrote: > Sam Leffler wrote: > >Scott Long wrote: > > > >>Sam Leffler wrote: > >> > >>>Scott Long wrote: > >>> > >>>>The architecture of the driver makes this a request hard to do. I > >>>>don't like it, but there is precedence already with the ath driver. > >>> > >>> > >>> > >>>I'm guessing you're referring to ath bailing if the hal could not be > >>>attached or the card otherwise setup? If so the card was actually > >>>recognized and failure to complete the attach is totally separate. > >>> > >>>ath doesn't print anything during probe. > >>> > >>> Sam > >> > >> > >>I thought that the ath hal printed a line early in boot with the > >>version number. > > > > > >The hal is a separate module. It prints it's version string on module > >load. I can put it under bootverbose if desired but it's way useful to > >tell people to send me: > > > >dmesg|grep ath > > > >and get the hal version and mac+phy revs for the hardware. > > > > Sam > > The same is basically true of rr232x, though there is no module > separation of HAL vs OSM like with ath. > > Scott >