From owner-freebsd-net@FreeBSD.ORG  Mon Mar 11 12:30:01 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 95B7B6D6
 for <freebsd-net@smarthost.ysv.freebsd.org>;
 Mon, 11 Mar 2013 12:30:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 703B3E12
 for <freebsd-net@smarthost.ysv.freebsd.org>;
 Mon, 11 Mar 2013 12:30:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2BCU1P0008114
 for <freebsd-net@freefall.freebsd.org>; Mon, 11 Mar 2013 12:30:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2BCU1cw008113;
 Mon, 11 Mar 2013 12:30:01 GMT (envelope-from gnats)
Date: Mon, 11 Mar 2013 12:30:01 GMT
Message-Id: <201303111230.r2BCU1cw008113@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: kern/176667: commit references a PR
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Mar 2013 12:30:01 -0000

The following reply was made to PR kern/176667; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/176667: commit references a PR
Date: Mon, 11 Mar 2013 12:22:52 +0000 (UTC)

 Author: glebius
 Date: Mon Mar 11 12:22:44 2013
 New Revision: 248158
 URL: http://svnweb.freebsd.org/changeset/base/248158
 
 Log:
   Remove LIBALIAS_LOCK_ASSERT(), including a couple with an uninitialzed
   argument, in code that isn't compiled in kernel.
   
   PR:		kern/176667
   Sponsored by:	Nginx, Inc.
 
 Modified:
   head/sys/netinet/libalias/alias_db.c
 
 Modified: head/sys/netinet/libalias/alias_db.c
 ==============================================================================
 --- head/sys/netinet/libalias/alias_db.c	Mon Mar 11 12:14:20 2013	(r248157)
 +++ head/sys/netinet/libalias/alias_db.c	Mon Mar 11 12:22:44 2013	(r248158)
 @@ -2729,7 +2729,6 @@ static void
  InitPunchFW(struct libalias *la)
  {
  
 -	LIBALIAS_LOCK_ASSERT(la);
  	la->fireWallField = malloc(la->fireWallNumNums);
  	if (la->fireWallField) {
  		memset(la->fireWallField, 0, la->fireWallNumNums);
 @@ -2745,7 +2744,6 @@ static void
  UninitPunchFW(struct libalias *la)
  {
  
 -	LIBALIAS_LOCK_ASSERT(la);
  	ClearAllFWHoles(la);
  	if (la->fireWallFD >= 0)
  		close(la->fireWallFD);
 @@ -2765,7 +2763,6 @@ PunchFWHole(struct alias_link *lnk)
  	struct ip_fw rule;	/* On-the-fly built rule */
  	int fwhole;		/* Where to punch hole */
  
 -	LIBALIAS_LOCK_ASSERT(la);
  	la = lnk->la;
  
  /* Don't do anything unless we are asked to */
 @@ -2839,7 +2836,6 @@ ClearFWHole(struct alias_link *lnk)
  {
  	struct libalias *la;
  
 -	LIBALIAS_LOCK_ASSERT(la);
  	la = lnk->la;
  	if (lnk->link_type == LINK_TCP) {
  		int fwhole = lnk->data.tcp->fwhole;	/* Where is the firewall
 @@ -2864,7 +2860,6 @@ ClearAllFWHoles(struct libalias *la)
  	struct ip_fw rule;	/* On-the-fly built rule */
  	int i;
  
 -	LIBALIAS_LOCK_ASSERT(la);
  	if (la->fireWallFD < 0)
  		return;
  
 @@ -2878,7 +2873,7 @@ ClearAllFWHoles(struct libalias *la)
  	memset(la->fireWallField, 0, la->fireWallNumNums);
  }
  
 -#endif
 +#endif /* !NO_FW_PUNCH */
  
  void
  LibAliasSetFWBase(struct libalias *la, unsigned int base, unsigned int num)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"