From owner-freebsd-emulation@FreeBSD.ORG  Sat Aug  2 22:22:40 2008
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B9644106567D;
	Sat,  2 Aug 2008 22:22:40 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id 6956E8FC16;
	Sat,  2 Aug 2008 22:22:40 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 414D768B494;
	Sun,  3 Aug 2008 00:21:23 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id P6dZ+wxT71A3; Sun,  3 Aug 2008 00:21:09 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id BB6CC68B487;
	Sun,  3 Aug 2008 00:21:09 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.14.2/8.14.2/Submit) id m72ML9W0078238;
	Sun, 3 Aug 2008 00:21:09 +0200 (CEST) (envelope-from rdivacky)
Date: Sun, 3 Aug 2008 00:21:09 +0200
From: Roman Divacky <rdivacky@freebsd.org>
To: Chagin Dmitry <chagin.dmitry@gmail.com>
Message-ID: <20080802222109.GA78151@freebsd.org>
References: <alpine.BSF.1.10.0807231236140.12600@thor.farley.org>
	<alpine.BSF.1.10.0808030024140.81282@ora.chd.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.BSF.1.10.0808030024140.81282@ora.chd.net>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-emulation@freebsd.org
Subject: Re: [PATCH]Re: kern/122318 (CMake core dumping, chroot exiting)
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Aug 2008 22:22:40 -0000

On Sun, Aug 03, 2008 at 12:53:58AM +0400, Chagin Dmitry wrote:
> On Wed, 23 Jul 2008, Sean C. Farley wrote:
> 
> >I am seeing if anyone has any insight on this PR (kern/122318[1]).  It
> >would be nice to once again build using cmake within a Linux chroot.  :)
> >
> >Basically, the bug is that not only that cmake is dumping core; it is
> >also forcing the user out of the chroot environment.  Here is the
> >command used to start the chroot:
> >/compat/linux/usr/sbin/chroot <chroot path> su - <build user>
> >
> >Thank you.
> >
> >Sean
> > 1. http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/122318
> >
> 
> here patches for -current and releng_7:
> http://78.107.232.239/rt_signals-current.patch
> http://78.107.232.239/rt_signals-releng_7.patch
> 
> what patch do:
> - rt sigtramp code works (this solves PR)
> - align stack pointers
> - remove kern_sigaltstack() at the end of rt_sigreturn(), it's a bogus.
>   Here there is some information on it:
>   http://www.ussg.iu.edu/hypermail/linux/kernel/0405.2/1283.html

I quickly skimmed over it and it looks correct, but please avoid
making gratuitous changes like moving stuff before comment after
the comment etc.

I will do a little more thorough review but so far it looks good

great work dmitry!

roman