From owner-freebsd-current@FreeBSD.ORG Mon Mar 27 14:12:08 2006 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8185216A400; Mon, 27 Mar 2006 14:12:08 +0000 (UTC) (envelope-from ast@marabu.ch) Received: from oneplusone.ch (oneplusone.ch [212.55.208.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85B4543D45; Mon, 27 Mar 2006 14:12:05 +0000 (GMT) (envelope-from ast@marabu.ch) Received: from oneplusone.ch (localhost [127.0.0.1]) by oneplusone.ch (8.13.4/8.13.4) with ESMTP id k2REC1w8019289 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 27 Mar 2006 16:12:02 +0200 (CEST) (envelope-from ast@marabu.ch) Received: (from uucp@localhost) by oneplusone.ch (8.13.4/8.13.4/Submit) with UUCP id k2REC112019288; Mon, 27 Mar 2006 16:12:01 +0200 (CEST) (envelope-from ast@marabu.ch) Received: from [192.168.21.5] (ardea.marabu.ch [192.168.21.5]) by pano.marabu.ch (8.13.4/8.13.4) with ESMTP id k2RE9NHD056602; Mon, 27 Mar 2006 16:09:23 +0200 (CEST) (envelope-from ast@marabu.ch) In-Reply-To: <44279BAC.4020904@micom.mng.net> References: <20060325180630.V31295@pano.marabu.ch> <44279BAC.4020904@micom.mng.net> Mime-Version: 1.0 (Apple Message framework v746.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Adrian Steinmann Date: Mon, 27 Mar 2006 16:09:21 +0200 To: Ganbold X-Mailer: Apple Mail (2.746.3) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 (oneplusone.ch [127.0.0.1]); Mon, 27 Mar 2006 16:12:03 +0200 (CEST) X-Mailfilter: egfilter version 1.14; Archiver [msg.SDKo1q7r] (oneplusone.ch [127.0.0.1]); Mon, 27 Mar 2006 16:12:03 +0200 (CEST) X-AntiVirus: checked by AntiVir Milter (version: 1.1.2-1; AVE: 6.34.0.14; VDF: 6.34.0.102; host: oneplusone.ch) Cc: freebsd-current@FreeBSD.org, dougb@FreeBSD.org Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2006 14:12:08 -0000 On Mar 27, 2006, at 10:00, Ganbold wrote: > I tested your test script and found out the way to avoid core dump > in rcorder. > I didn't quite get the #if 0 lines that you provide in patch. well, my #if 0 was just a way to "comment out" those free() calls... I didn't check Dragonfly but simply suspected freeing too early. It was a mistake to leave that in for the PR, it was just a local test. > So I'm bit confused here which type of patch we should apply. > I guess we should follow Dragonfly. Maybe I' wrong. > Can somebody enlighten me here? It seems there was a "cleanup" in rcorder.c lately, and maybe those introduced the bugs. But commenting (or #ifdef-ing out) those free()'s is probably better than having rcorder dump core. I just reworked my solution not to use rcorder but tsort... I know that doesn't help here, sorry. Adrian