From owner-p4-projects@FreeBSD.ORG  Sat May 10 17:25:52 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 08BED37B401; Sat, 10 May 2003 17:25:52 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9D6D137B405
	for <perforce@freebsd.org>; Sat, 10 May 2003 17:25:51 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4447843FDF
	for <perforce@freebsd.org>; Sat, 10 May 2003 17:25:51 -0700 (PDT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h4B0Pp0U022284
	for <perforce@freebsd.org>; Sat, 10 May 2003 17:25:51 -0700 (PDT)
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h4B0PooJ022281
	for perforce@freebsd.org; Sat, 10 May 2003 17:25:50 -0700 (PDT)
Date: Sat, 10 May 2003 17:25:50 -0700 (PDT)
Message-Id: <200305110025.h4B0PooJ022281@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 30928 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 May 2003 00:25:53 -0000

http://perforce.freebsd.org/chv.cgi?CH=30928

Change 30928 by marcel@marcel_nfs on 2003/05/10 17:24:54

	Use bcopy and copyin/copyout to read and write bytes. This
	avoids a page fault caused by the debugger trying to read
	or write from/to a bogus address. Keep the jmp_buf for now.

Affected files ...

.. //depot/projects/ia64_epc/sys/ia64/ia64/db_interface.c#9 edit

Differences ...

==== //depot/projects/ia64_epc/sys/ia64/ia64/db_interface.c#9 (text+ko) ====

@@ -403,13 +403,13 @@
 	register size_t	size;
 	register char	*data;
 {
-	register char	*src;
 
 	db_nofault = &db_jmpbuf;
 
-	src = (char *)addr;
-	while (size-- > 0)
-		*data++ = *src++;
+	if (addr < VM_MAX_ADDRESS)
+		copyin((char *)addr, data, size);
+	else
+		bcopy((char *)addr, data, size);
 
 	db_nofault = 0;
 }
@@ -423,13 +423,13 @@
 	register size_t	size;
 	register char	*data;
 {
-	register char	*dst;
 
 	db_nofault = &db_jmpbuf;
 
-	dst = (char *)addr;
-	while (size-- > 0)
-		*dst++ = *data++;
+	if (addr < VM_MAX_ADDRESS)
+		copyout(data, (char *)addr, size);
+	else
+		bcopy(data, (char *)addr, size);
 
 	db_nofault = 0;
 }