Date: Tue, 30 Oct 2007 22:10:36 +0200 From: Giorgos Keramidas <keramida@freebsd.org> To: Mike Makonnen <mtm@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/route route.c Message-ID: <20071030201036.GA1413@kobe.laptop> In-Reply-To: <200710290008.l9T08Odw067359@repoman.freebsd.org> References: <200710290008.l9T08Odw067359@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2007-10-29 00:08, Mike Makonnen <mtm@freebsd.org> wrote: > mtm 2007-10-29 00:08:24 UTC > > FreeBSD src repository > > Modified files: > sbin/route route.c > Log: > Fix an error in bit shifting logic for network addresses. The route > command would add incorrect routing entries if network numbers weren't > fully "spelled" out according to their class. For example: > # route add 128.0/16 (works) > # route add 128/16 (doesn't work) > [...] > Submitted by: Nuno Antunes <nuno.antunes@gmail.com> (mostly) > MFC after: 1 week > > Revision Changes Path > 1.82 +24 -20 src/sbin/route/route.c Thank you Mike! Almost identical to the patch I was testing a while back, including better netmask handling parts :-) Nuno has also mentioned that `netstat -rn' gets things wrong; do you have a WIP for that too? Do you need help with testing?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071030201036.GA1413>