From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jun 4 14:10:04 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E1D91065672 for ; Wed, 4 Jun 2008 14:10:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 25BC08FC12 for ; Wed, 4 Jun 2008 14:10:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m54EA4xi041272 for ; Wed, 4 Jun 2008 14:10:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m54EA4it041271; Wed, 4 Jun 2008 14:10:04 GMT (envelope-from gnats) Resent-Date: Wed, 4 Jun 2008 14:10:04 GMT Resent-Message-Id: <200806041410.m54EA4it041271@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, James Kelly Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B199B1065675 for ; Wed, 4 Jun 2008 14:05:55 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 9B6428FC28 for ; Wed, 4 Jun 2008 14:05:55 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m54E5tVl035982 for ; Wed, 4 Jun 2008 14:05:55 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m54E5sp4035981; Wed, 4 Jun 2008 14:05:54 GMT (envelope-from nobody) Message-Id: <200806041405.m54E5sp4035981@www.freebsd.org> Date: Wed, 4 Jun 2008 14:05:54 GMT From: James Kelly To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/124271: Portmaster can miss deps if previous port has CONFLICTS and current one does not X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2008 14:10:04 -0000 >Number: 124271 >Category: ports >Synopsis: Portmaster can miss deps if previous port has CONFLICTS and current one does not >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jun 04 14:10:03 UTC 2008 >Closed-Date: >Last-Modified: >Originator: James Kelly >Release: 6.3-RELEASE-p2 >Organization: Tilted Planet, Ltd. >Environment: FreeBSD crinoid.build.psq.ord.tilted.net 6.3-RELEASE-p2 FreeBSD 6.3-RELEASE-p2 #4: Mon Apr 28 07:37:08 CDT 2008 jjk@stubby.tilted.net:/usr/build/FreeBSD_6_3/obj/amd64/usr/build/FreeBSD_6_3/src/sys/DELLYKINS amd64 >Description: When checking dependencies of a port and the port has multiple dependencies, the conflicts list of the previous port will be re-used if the current port does not have any conflicts. This can result in not installing some dependencies. It may just be runtime-dependencies that it can miss -- it only showed up for me when working on runtime-dependencies in databases/mytop. Most likely though, it can show up in all forms of dependency resolution. >How-To-Repeat: "sudo portmaster databases/mytop" on a system without all of it's runtime deps installed. >Fix: unset or set conflicts to a blank value before looking for CONFLICTS in the probed port's Makefile. I've attached a patch to set conflicts to a blank value, which fixes this problem for me. Patch attached with submission follows: Index: ports/ports-mgmt/portmaster/files/portmaster.sh.in =================================================================== --- ports/ports-mgmt/portmaster/files/portmaster.sh.in (revision 2275) +++ ports/ports-mgmt/portmaster/files/portmaster.sh.in (revision 2276) @@ -1453,6 +1453,7 @@ [ -z "$URB_YES" ] && case "$CUR_DEPS" in *:${origin}:*) continue ;; esac + conflicts='' if pm_cd $d_port; then grep -ql ^CONFLICTS Makefile && conflicts=`pm_make_b -V CONFLICTS` >Release-Note: >Audit-Trail: >Unformatted: