From nobody Thu Jul 17 16:01:50 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bjd326ryHz61wfq; Thu, 17 Jul 2025 16:01:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bjd322s6kz3d4Q; Thu, 17 Jul 2025 16:01:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752768110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lyfDX6abtDoBqEI98UbcmwjovUMa/NKWiokjt4nvhsU=; b=eAEm/rubXoawgwDG7zBLwoOSq2sJlSNd0K8GIMuDbZkGC344uUc9Cq70ruScblVuCnSz80 pWMqbE6ChDhuWWRJ/PpUQhLkZf+h2/SGqOKMZYyzVpAmCaaOYP8BHt2Q9DpJ0kZWuK7pgv d5TRTjPtxWUVlR1UByockj1TFu3n7tfWGEORx9qJ7E8cBTt8V2nBMSe2munLExqKl5jKxQ RODFnce/IQM3vPPQONY6gs9Z5UAQPjjTmx3ahhYm8RrdHxA4xL+yBljvYB3nG4o3GQHYyn wqdGU+CfugfoiNyndbpvdqjIHFpS7Z2dCHxEMaR1qKj1vsZScPukZYowl3lV6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752768110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lyfDX6abtDoBqEI98UbcmwjovUMa/NKWiokjt4nvhsU=; b=PAu7c1MKRQZlzM1nCnvd+SoqME5f4WNruL7N0eVDik8kVb4c9Hc5+Zd/57hdqQNpiC3I83 0CNSVo8qNffa5gqgUdNtNXv9ROrb2/UwOV+RhUMcZAjtgJGinchkkJjFc1sXR4MlvuYwc9 XE2IbaQSLEgWSF/vxStTxz8TqGKzDSQp9+T/Kx1rTBgra//Sv0s7z8Vs0GREkMutamoOS1 4498sSjaMMe7C1UlOkPfwyLNlKvfgvcECcYbUKVAkdndquIhC8UeTmJld/UzUTTgzk+yFL JxDfwO1iwsmHcaiEjO60flN2P1a3ivd8ozqScu/g0ia55Kp2R87lyBWOlTxpEQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752768110; a=rsa-sha256; cv=none; b=NAQT/rxMnEGDDo+7ucJDGrSq24FTrtMoKAow0Ku6LJOWyqaiAPO1Sy3UHSJyBE9FcPiEE+ AgqH1u6VMzVfgbT9kbOZYUodqFAv1giXpk26XkLSNbSwuSV1UQdtMk80Ct3/nlnFx8h2fI yWyBmsPiSYJ35iziwEw9WZxLjlEDMAIaf6QWXaHbSIsDQmohbg9pXcKwbl7hmT+OTiCuXV Y60y+0LjrxaX4rmOQYSrGnab/Q889UfS5HdvHM/LH+8ETrU81mMFowtzlIgMKQVq2ly65x ZeJ6QUHE/Q9TUAeGcj++hgKMUKiu2WyTx/86JleWAvgu6VVNqDEVYVTEXvLaFg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bjd322KrBz129N; Thu, 17 Jul 2025 16:01:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56HG1o6t032876; Thu, 17 Jul 2025 16:01:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56HG1o1d032873; Thu, 17 Jul 2025 16:01:50 GMT (envelope-from git) Date: Thu, 17 Jul 2025 16:01:50 GMT Message-Id: <202507171601.56HG1o1d032873@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 3c29b47bbc0a - main - bsnmpd: in debugging mode (-d) use default library print/error functions List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3c29b47bbc0a107c2bda0c103fc8c6de2cbddee8 Auto-Submitted: auto-generated The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=3c29b47bbc0a107c2bda0c103fc8c6de2cbddee8 commit 3c29b47bbc0a107c2bda0c103fc8c6de2cbddee8 Author: Gleb Smirnoff AuthorDate: 2025-07-17 16:00:44 +0000 Commit: Gleb Smirnoff CommitDate: 2025-07-17 16:00:44 +0000 bsnmpd: in debugging mode (-d) use default library print/error functions We want to see debugging on stderr in non-daemon mode, otherwise this mode has little value. Reviewed by: harti Differential Revision: https://reviews.freebsd.org/D51356 --- contrib/bsnmp/snmpd/main.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/contrib/bsnmp/snmpd/main.c b/contrib/bsnmp/snmpd/main.c index 928b84121f82..c77572934d24 100644 --- a/contrib/bsnmp/snmpd/main.c +++ b/contrib/bsnmp/snmpd/main.c @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include @@ -1509,7 +1510,7 @@ main(int argc, char *argv[]) { int opt; FILE *fp; - int background = 1; + bool background = true; struct tport *p; const char *prefix = "snmpd"; struct lmodule *m; @@ -1526,11 +1527,6 @@ main(int argc, char *argv[]) NULL }; - snmp_printf = snmp_printf_func; - snmp_error = snmp_error_func; - snmp_debug = snmp_debug_func; - asn_error = asn_error_func; - while ((opt = getopt(argc, argv, "c:dD:e:hI:l:m:p:")) != EOF) switch (opt) { @@ -1539,7 +1535,7 @@ main(int argc, char *argv[]) break; case 'd': - background = 0; + background = false; break; case 'D': @@ -1601,6 +1597,13 @@ main(int argc, char *argv[]) break; } + if (background) { + snmp_printf = snmp_printf_func; + snmp_error = snmp_error_func; + snmp_debug = snmp_debug_func; + asn_error = asn_error_func; + } + openlog(prefix, LOG_PID | (background ? 0 : LOG_PERROR), LOG_USER); setlogmask(LOG_UPTO(debug.logpri - 1));