From nobody Tue Sep 26 12:45:16 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RvzxB2W97z4v6PL; Tue, 26 Sep 2023 12:45:34 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rvzx94F1Yz3X9r; Tue, 26 Sep 2023 12:45:33 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com; dmarc=none Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5031ccf004cso14146852e87.2; Tue, 26 Sep 2023 05:45:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695732329; x=1696337129; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AFz5w5+4rjpOB0ZgD3Lh8n9gFlRjSs8cX197G9F74g4=; b=gG4Z2xpyQQdLaRsX2Qb+862sdT3qdbZwiNMita/vxNEtvmL1M+OWzCjp56EGX6uaQf p4a+Te9RR1N12F9KykzkMs37kCUW6JUULgzQbzCe/Uewx7cS1ZBGbyoqNFdRCtBGQ5un grNkW/7sScr6waRiPe03HchFAVfs23BXx9BL0XBZ5kPDJROv49jjFBATjlf8StLvWC+Z LBe6zRZ0b5lN3K2zFVLskOovTnMkNsiBPvU3tF8iU388OfsxQpcy96ck/qLFUaV+9tn7 O3aRN7NNI7j4X3o1nM2n6kfPbMgXcOgM/EhNvnJwgJUVIC/BLN3RupuQgt8j3qXjwhFr RHtA== X-Gm-Message-State: AOJu0YzS4s8CQ14+92+4RSB49432KK76ukttip88hxo1/pxfNUTWPJVs S+k+2FicTDKMljOL8NnKMEWIq0p4yAn+LqjGySiVbSsD9PK4SqUn X-Google-Smtp-Source: AGHT+IHw0jpheuJb3YpIAXXCcsU9Xw8j+B+oaabO2kjG0ZJOBfcEjFXpEq1PkFcCLUegc9XeQDnC3/RAwhMA49/md/Q= X-Received: by 2002:ac2:57db:0:b0:4fd:8976:5fc9 with SMTP id k27-20020ac257db000000b004fd89765fc9mr7524742lfo.23.1695732329129; Tue, 26 Sep 2023 05:45:29 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202309260506.38Q560jI057529@gitrepo.freebsd.org> In-Reply-To: <202309260506.38Q560jI057529@gitrepo.freebsd.org> From: Ed Maste Date: Tue, 26 Sep 2023 08:45:16 -0400 Message-ID: Subject: Re: git: 915af883221a - main - Explain the -d option. To: src-committers Cc: dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.96 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.96)[-0.958]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_ONE(0.00)[1]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; R_DKIM_NA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.54:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.54:from]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[carpeddiem]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCPT_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[freebsd.org]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com] X-Rspamd-Queue-Id: 4Rvzx94F1Yz3X9r > The branch main has been updated by grog: > > URL: https://cgit.FreeBSD.org/src/commit/?id=915af883221a4982e89ef878f1def0899ccac283 > ... > Explain the -d option. Not picking on this commit specifically but it's a good opportunity for a reminder that we have a comprehensive set of guidelines in the committer's guide: https://docs.freebsd.org/en/articles/committers-guide/#commit-log-message We've had some recent commits that don't follow the preferred format -- overly long lines, missing empty second line, etc. For this commit the issue is our preferred commit message subject format starts with a component. That is, for this commit the preferred commit message would be: makefs: Explain the -d option This makes it easy to find commits of interest in short logs, e.g. the five most recent commits as of now: $ git log --oneline freebsd/main | head -n 5 915af883221a Explain the -d option. 1d6021cd7268 nvme: Supress noise messages 1117b3204873 pf.4: Bump .Dd 3fb80f1476c7 regcomp: use unsigned char when testing for escapes 61f8df6a13a3 mfc-candidates: search by committer only, not author