From owner-svn-src-all@FreeBSD.ORG Fri Oct 24 16:01:58 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09BA01065673; Fri, 24 Oct 2008 16:01:58 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id CFDE28FC39; Fri, 24 Oct 2008 16:01:57 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m9OG1to8004307 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 24 Oct 2008 09:01:55 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <4901F173.2070701@freebsd.org> Date: Fri, 24 Oct 2008 09:01:55 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: marcel@freebsd.org References: <200810230151.m9N1ptUe044619@svn.freebsd.org> <20081023.190942.74668946.imp@bsdimp.com> In-Reply-To: <20081023.190942.74668946.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC--Metrics: ebb.errno.com; whitelist Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh Subject: Re: svn commit: r184193 - in head/sys: arm/conf conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Oct 2008 16:01:58 -0000 Warner Losh wrote: > From: Marcel Moolenaar > Subject: svn commit: r184193 - in head/sys: arm/conf conf > Date: Thu, 23 Oct 2008 01:51:55 +0000 (UTC) > > >> Author: marcel >> Date: Thu Oct 23 01:51:55 2008 >> New Revision: 184193 >> URL: http://svn.freebsd.org/changeset/base/184193 >> >> Log: >> Add arm/conf/DEFAULTS and populate it with: >> machine arm >> device mem >> options GEOM_BSD >> options GEOM_MBR >> >> Remove the first two from all kernel configuration files and >> change geom_bsd and geom_mbr from standard to optional. >> >> Added: >> head/sys/arm/conf/DEFAULTS (contents, props changed) >> > > We already have a better mechanism for including config files. We > should be using that instead of poluting another port with the > DEFAULTS file. > More importantly this change forces GEOM_BSD and GEOM_MBR on every target platform. This is just wrong and clearly Marvel never discussed it with anyone working on arm systems or he'd have gotten an earful. Marcel, please back this stuff out. Sam