From owner-svn-ports-head@FreeBSD.ORG Sun Mar 31 16:17:01 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 08629632; Sun, 31 Mar 2013 16:17:01 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ie0-x230.google.com (mail-ie0-x230.google.com [IPv6:2607:f8b0:4001:c03::230]) by mx1.freebsd.org (Postfix) with ESMTP id 96A90265; Sun, 31 Mar 2013 16:17:00 +0000 (UTC) Received: by mail-ie0-f176.google.com with SMTP id x14so1717342ief.7 for ; Sun, 31 Mar 2013 09:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=P3fagkfnprM1ihbwyNGEf+jMrfdK0RasN141TKqxEdo=; b=I93eFbyjcDQtWcO732gw0HlUy5DipAzHqygQDYqXEF2VXOJz3P8RbglsoVE7SD9SGz s7StSFQr8oGdpbAxJpd4A1OXsAvj5l9rc0farF52qLGy5r+RcYVGgWAgXL4gOnFcPYUN vU8me7YkBTlM9JgqeQNn3xN+BOcPktShbbWpIGmUHZrnnDk+HbmDNDXenlUbILhiz8JY Gl8VQJjkTBo0MiN3sABzlyI0LDV8/mk1AfIjt3WX0HUIXMD28V8L/7yqwwIJg2Zb7GbE Ka6/wmsuA6LwxbVJ9AIOaWiTXBV9NpOZ00aThniZKQXks8FhDt/bWkhiO9WFTDI3ZqIS iXPw== X-Received: by 10.50.152.169 with SMTP id uz9mr2511452igb.15.1364746620238; Sun, 31 Mar 2013 09:17:00 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.64.58.52 with HTTP; Sun, 31 Mar 2013 09:16:30 -0700 (PDT) In-Reply-To: <5158602E.7070101@FreeBSD.org> References: <201303302045.r2UKj1wS062090@svn.freebsd.org> <51575F46.3050807@freebsd.org> <5158602E.7070101@FreeBSD.org> From: Chris Rees Date: Sun, 31 Mar 2013 17:16:30 +0100 X-Google-Sender-Auth: RfsE24VvOMjordnv_fmkH9twRac Message-ID: Subject: Re: svn commit: r315624 - head/net/wireshark To: Bryan Drewery Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-ports-head@freebsd.org" , svn-ports-all@freebsd.org, "ports-committers@freebsd.org" , Joe Marcus Clarke , Niclas Zeising , =?ISO-8859-1?Q?Beat_G=E4tzi?= X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Mar 2013 16:17:01 -0000 On 31 March 2013 17:11, Bryan Drewery wrote: > On 3/31/2013 11:02 AM, Chris Rees wrote: >> On 30 March 2013 21:55, Niclas Zeising wrote: >>> On 03/30/13 21:45, Joe Marcus Clarke wrote: >>>> Author: marcus >>>> Date: Sat Mar 30 20:45:00 2013 >>>> New Revision: 315624 >>>> URL: http://svnweb.freebsd.org/changeset/ports/315624 >>>> >>>> Log: >>>> Make pkgconfig an explicit dependency of tshark. >>>> >>>> Modified: >>>> head/net/wireshark/Makefile >>>> >>>> Modified: head/net/wireshark/Makefile >>>> ============================================================================== >>>> --- head/net/wireshark/Makefile Sat Mar 30 18:54:34 2013 (r315623) >>>> +++ head/net/wireshark/Makefile Sat Mar 30 20:45:00 2013 (r315624) >>>> @@ -75,7 +75,7 @@ USE_GNOME+= gtk20 >>>> WIRESHARK_LIBS+=${PTHREAD_LIBS} >>>> .else >>>> PLIST_SUB+= WIRESHARK="@comment wireshark not built" >>>> -USE_GNOME+= glib20 >>>> +USE_GNOME+= glib20 pkgconfig >>>> CONFIGURE_ARGS+= --enable-wireshark=no \ >>>> --disable-gtktest >>>> .endif >>>> >>> >>> You should use USE_PKGCONFIG=build instead. >>> >>> A completely other thing: >>> Isn't the ports tree frozen these days and require a Approved by: >>> portmgr line in the commit msg? Perhaps something isn't working as it >>> should there. >>> Regards! >> >> Those hooks are not working at the moment, though I don't remember if >> I specifically told Beat about it or just complained. >> >> I've copied him in just in case he didn't know. >> >> Another example: >> >> http://svnweb.freebsd.org/ports/svnadmin/conf/access?revision=314635&view=markup >> >> Chris >> > > The hook is working. portmgr are explicitly exempt from the check for > "Approved by". See svnadmin/hooks/scripts/approvecheck.pl Maybe I'm being picky, but the traditional method for this is to use Approved by: portmgr (implicit) or Approved by: portmgr (self); have a look at how it's done in base: http://svnweb.freebsd.org/base/svnadmin/conf/access?revision=245526&view=markup This makes it more explicit for the history when people nose back years later [yes, there are people sad enough to do that]. Chris