From owner-freebsd-current@FreeBSD.ORG  Sat Aug  1 17:12:12 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1F34A106566B;
	Sat,  1 Aug 2009 17:12:12 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (kientzle.com [66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 6F0DC8FC20;
	Sat,  1 Aug 2009 17:12:11 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: (from root@localhost)
	by kientzle.com (8.14.3/8.14.3) id n71HC7ir061638;
	Sat, 1 Aug 2009 10:12:07 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Received: from dark.x.kientzle.com (fw2.kientzle.com [10.123.1.2])
	by kientzle.com with SMTP id vbwmjdtehhcjv7yi7zxb5zd3pi;
	Sat, 01 Aug 2009 10:12:07 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Message-ID: <4A747766.10901@freebsd.org>
Date: Sat, 01 Aug 2009 10:12:06 -0700
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.8.1.21) Gecko/20090601 SeaMonkey/1.1.16
MIME-Version: 1.0
To: "James R. Van Artsdalen" <james-freebsd-fs2@jrv.org>
References: <20090727072503.GA52309@jpru.ffm.jpru.de>	<20090729084723.GD1586@garage.freebsd.pl>	<F4F82B3E-C119-40EF-9AA4-937052876D1E@exscape.org>	<4A7030B6.8010205@icyb.net.ua>	<97D5950F-4E4D-4446-AC22-92679135868D@exscape.org>	<4A7048A9.4020507@icyb.net.ua>	<52AA86CB-6C06-4370-BA73-CE19175467D0@exscape.org>	<4A705299.8060504@icyb.net.ua>	<D3491B77-DA5C-4E10-BE1D-D6EF8CFB112E@exscape.org>	<4A7054E1.5060402@icyb.net.ua>	<5918824D-A67C-43E6-8685-7B72A52B9CAE@exscape.org>	<4A705E50.8070307@icyb.net.ua>	<4A70728C.7020004@freebsd.org>	<6D47A34B-0753-4CED-BF3D-C505B37748FC@exscape.org>	<4A708455.5070304@freebsd.org>	<86983A55-E5C4-4C04-A4C7-0AE9A9EE37A3@exscape.org>	<4A718E03.6030909@freebsd.org>	<71A038EC-02B1-4606-96C2-5E84BE80F005@exscape.org>	<4A719CA4.4060400@freebsd.org>	<19347561-3CE6-40B3-930A-EB9925D3AFD1@exscape.org>	<4A71AD29.10705@freebsd.org>	<7544AED1-1216-4A24-B287-F54117641F76@exscape.org>	<4A71B2DA.9060902@freebsd.org>
	<4A72D946.4090401@jrv.org>
In-Reply-To: <4A72D946.4090401@jrv.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-fs@freebsd.org, FreeBSD current <freebsd-current@freebsd.org>,
	Pawel Jakub Dawidek <pjd@freebsd.org>,
	Thomas Backman <serenity@exscape.org>, Andriy Gapon <avg@freebsd.org>
Subject: Re: zfs: Fatal trap 12: page fault while in kernel mode
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Aug 2009 17:12:12 -0000

James R. Van Artsdalen wrote:
> Andriy Gapon wrote:
>>   
>> One comment on the patch - I personally don't like bit-wise xor in a logical
>> expression. But if otherwise the expression would be huge and ugly, then OK.
> 
> If you're going to code an XOR, use an XOR.

Or != which produces the same result for logical
values and is sometimes easier to understand.

Tim