From nobody Thu Mar 26 01:16:00 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fh5Sd0jPjz6X4ST for ; Thu, 26 Mar 2026 01:16:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fh5Sc6Wyjz3Ldj for ; Thu, 26 Mar 2026 01:16:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774487760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pXmhYjRp0H4VYDSN/d61RUJyHgZrvUXFyZTo1vrlSMs=; b=w7zaEw1g9+2JtbSl9ns53WQAzmoSFn/PpwlRwOX4s+ldsOdyqPs3aEP7ZdWdsrKx37yUaf XGN7x4Dymy3T9fnPcGUtm/Vw6kW9slTRL8V6Q3B7gddFRGdrRisII3xWjwwBKLMngSiuPC N7SMajWPUpSSDMszUUufeRQK9Va48POobuO6vPAkwqBh7mbyn4lmKpGQwoSxZqUS9lQ4tM prq6rguXuc8gUdiiIx5d0zz405TjhCwjSMMEwjoVPKm+HT3VXZkuVqfm4GOr0v7kXV4V5Y q1f3weE3h9n2aADH5iTUdho6C+olzBxEex6kMFPhWR/WXyYEEOjSBja9z/ByjQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774487760; a=rsa-sha256; cv=none; b=s0wcxDwfUo554ZPA2VRTw3dCI85XyaqasGaFQ6cNpzxp69ipfATGMacwJOz4zy2JjrhQaW M/3S+z9BrLB4rRo3VszFI5sllEHlFO/x/2kS+4QM7a8VaGQw7E4Veco0kGjZi6XYZ/3xiL gypyJuvO/Wky3etR4rqDvJbYEIjzKYMq6kLCRLyVKqG+Y3jKsPIk+yBcK6u65jGXGiPXvU byXJb+bh3QUObR5EIhk1qRWTf54Ewvx6thBoV5u3lS5F1dhlSkNSiMTc9tHsf+IFJKLo8M ++o9DvjXqwAVo1oHLm774FP2er9VI35ROX9tzj2aDnBjBuSRq1zA4SVRvcU5pQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774487760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pXmhYjRp0H4VYDSN/d61RUJyHgZrvUXFyZTo1vrlSMs=; b=O89FiJUNOIG3jEbQaduo/ogkaSXg2qCPOTgOJQYV5dMlQ5uKCe6AGGduDfsajS544+uKUk 73ToV/uAfcAruTMhCQL5aX6sX3tx72ZzYeNUc/Ycwb7KzfbsbrRmF8YU9XrGg55RSPPPd+ T2Pdy0wDPnCFHJf6B/IlWXGguNOjuBH24iJmHUO+yqD9FJKJgtcjSxiGcA+khXJXn7kbry 7KKfMuxHQVrjHiOryn/APUuS69cPEfZKwiyD5cVGlmyik35xYsjHjdMwY3fjYXLMayENlv TxLP2P3X2CnwS8cJEwCEUD5s4bmHSrCAv/oKo8fvE9/f2oru4b0Hn6nXbfqa6w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fh5Sc5j2ZzVDc for ; Thu, 26 Mar 2026 01:16:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19088 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 26 Mar 2026 01:16:00 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Michael Tuexen From: Philip Paeps Subject: git: a9cba5321021 - releng/14.3 - tcp: plug an mbuf leak List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: philip X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.3 X-Git-Reftype: branch X-Git-Commit: a9cba5321021c5758c0c8bb65f9966bef01096fd Auto-Submitted: auto-generated Date: Thu, 26 Mar 2026 01:16:00 +0000 Message-Id: <69c488d0.19088.1af0dcf9@gitrepo.freebsd.org> The branch releng/14.3 has been updated by philip: URL: https://cgit.FreeBSD.org/src/commit/?id=a9cba5321021c5758c0c8bb65f9966bef01096fd commit a9cba5321021c5758c0c8bb65f9966bef01096fd Author: Michael Tuexen AuthorDate: 2026-03-25 05:53:56 +0000 Commit: Philip Paeps CommitDate: 2026-03-25 06:56:19 +0000 tcp: plug an mbuf leak When a challenge ACK should be sent via tcp_send_challenge_ack(), but the rate limiter suppresses the sending, free the mbuf chain. The caller of tcp_send_challenge_ack() expects this similar to the callers of tcp_respond(). Approved by: so Security: FreeBSD-SA-26:06.tcp Security: CVE-2026-4247 Reviewed by: lstewart Tested by: lstewart Sponsored by: Netflix, Inc. --- sys/netinet/tcp_subr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c index d17b46d13038..16871d7d8288 100644 --- a/sys/netinet/tcp_subr.c +++ b/sys/netinet/tcp_subr.c @@ -2256,6 +2256,8 @@ tcp_send_challenge_ack(struct tcpcb *tp, struct tcphdr *th, struct mbuf *m) tcp_respond(tp, mtod(m, void *), th, m, tp->rcv_nxt, tp->snd_nxt, TH_ACK); tp->last_ack_sent = tp->rcv_nxt; + } else { + m_freem(m); } }