From owner-freebsd-bugs@FreeBSD.ORG Thu Feb 7 10:40:01 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D181516A420 for ; Thu, 7 Feb 2008 10:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A315213C46E for ; Thu, 7 Feb 2008 10:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m17Ae1kh056828 for ; Thu, 7 Feb 2008 10:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m17Ae1I3056827; Thu, 7 Feb 2008 10:40:01 GMT (envelope-from gnats) Resent-Date: Thu, 7 Feb 2008 10:40:01 GMT Resent-Message-Id: <200802071040.m17Ae1I3056827@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, CyberLeo Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2251416A468 for ; Thu, 7 Feb 2008 10:30:49 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 0303013C4EE for ; Thu, 7 Feb 2008 10:30:49 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m17ASi5N086272 for ; Thu, 7 Feb 2008 10:28:44 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m17ASiVU086261; Thu, 7 Feb 2008 10:28:44 GMT (envelope-from nobody) Message-Id: <200802071028.m17ASiVU086261@www.freebsd.org> Date: Thu, 7 Feb 2008 10:28:44 GMT From: CyberLeo To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/120341: twe pci parity error printf lacks terminating newline X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2008 10:40:01 -0000 >Number: 120341 >Category: kern >Synopsis: twe pci parity error printf lacks terminating newline >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Feb 07 10:40:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: CyberLeo >Release: RELENG_6_3 >Organization: CyberLeo.Net >Environment: FreeBSD mtumishi.cyberleo.net 6.3-RELEASE FreeBSD 6.3-RELEASE #2: Sat Jan 19 02:11:12 PST 2008 cyberleo@mtumishi.cyberleo.net:/usr/obj/usr/src/sys/MTUMISHI i386 >Description: twe(4) driver printf for TWE_STATUS_PCI_PARITY_ERROR message lacks terminating newline. Confirmed in CURRENT and 6x/7x branches. >How-To-Repeat: Use a 3ware card, cause a PCI parity error, watch dmesg or console log. >Fix: Apply the included patch. Patch attached with submission follows: --- sys/dev/twe/twe.c-orig Thu Feb 7 03:35:02 2008 +++ sys/dev/twe/twe.c Thu Feb 7 03:35:22 2008 @@ -1696,7 +1696,7 @@ } result = 1; if (status_reg & TWE_STATUS_PCI_PARITY_ERROR) { - twe_printf(sc, "PCI parity error: Reseat card, move card or buggy device present."); + twe_printf(sc, "PCI parity error: Reseat card, move card or buggy device present.\n"); twe_clear_pci_parity_error(sc); } if (status_reg & TWE_STATUS_PCI_ABORT) { >Release-Note: >Audit-Trail: >Unformatted: