From owner-cvs-all@FreeBSD.ORG Wed Jul 23 00:15:26 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D82D37B401; Wed, 23 Jul 2003 00:15:26 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 359B043F75; Wed, 23 Jul 2003 00:15:24 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id RAA21724; Wed, 23 Jul 2003 17:15:12 +1000 Date: Wed, 23 Jul 2003 17:15:11 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Poul-Henning Kamp In-Reply-To: <16474.1058916504@critter.freebsd.dk> Message-ID: <20030723170147.X1276@gamplex.bde.org> References: <16474.1058916504@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: "Alan L. Cox" cc: src-committers@FreeBSD.ORG cc: Bosko Milekic cc: Steve Kargl cc: cvs-src@FreeBSD.ORG cc: David Schultz cc: cvs-all@FreeBSD.ORG cc: Marcel Moolenaar Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 07:15:26 -0000 On Wed, 23 Jul 2003, Poul-Henning Kamp wrote: > In message <20030722231656.GA9715@HAL9000.homeunix.com>, David Schultz writes: > > Please remember that the problem at hand is getting -Werror back > on the kernel so we can catch issues like the warning in umtx. Straw problem. Kernel developers can easily turn off -Winline and turn on -Werror. I turned off -Winline in my version of the old version of -current that I use a few minutes after importing gcc, and never turned off -Werror: %%% Index: kern.mk =================================================================== RCS file: /home/ncvs/src/sys/conf/kern.mk,v retrieving revision 1.31 diff -u -2 -r1.31 kern.mk --- kern.mk 13 Oct 2002 02:52:22 -0000 1.31 +++ kern.mk 11 Jul 2003 14:45:37 -0000 @@ -8,5 +8,5 @@ # also pop up, but are easier to fix. CWARNFLAGS?= -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes \ - -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual \ + -Wmissing-prototypes -Wpointer-arith -Wcast-qual \ -fformat-extensions -ansi # %%% > We could either do that by lobotomizing the warning in the compiler > or by setting the limit high enough to inline everything so marked. > > Since the warning has indeed pointed out a fair number of bogus > inlines, the first option did not seem attractive. Turning off -Winline essentially gives the gcc-3.2 brokenness of -Winline without touching the compiler. -Winline has been turned off for a long time for the i386 LINT, as a side effect of the i386 LINT testing high resolution profiling and -Winline actually producing warnings for the high resolution profiling case (-finstrument-functions at least used to conflict with inliniing). No one seemed to notice when I turned it off. Bruce