From owner-svn-src-head@FreeBSD.ORG Thu Nov 7 20:34:38 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C9424DD5; Thu, 7 Nov 2013 20:34:38 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A62CC2C31; Thu, 7 Nov 2013 20:34:38 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.7/8.14.7) with ESMTP id rA7KYbjC060798; Thu, 7 Nov 2013 12:34:37 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.7/8.14.7/Submit) id rA7KYbTj060797; Thu, 7 Nov 2013 12:34:37 -0800 (PST) (envelope-from sgk) Date: Thu, 7 Nov 2013 12:34:37 -0800 From: Steve Kargl To: Ian Lepore Subject: Re: svn commit: r257770 - head/lib/msun/src Message-ID: <20131107203437.GA60686@troutmask.apl.washington.edu> References: <201311062344.rA6Niqkf001246@svn.freebsd.org> <1383854281.31172.214.camel@revolution.hippie.lan> <20131107201946.GA58797@troutmask.apl.washington.edu> <1383856221.31172.226.camel@revolution.hippie.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1383856221.31172.226.camel@revolution.hippie.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Steve Kargl X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Nov 2013 20:34:38 -0000 On Thu, Nov 07, 2013 at 01:30:21PM -0700, Ian Lepore wrote: > > > > I zero about floating-point on arm. Does long double have I know ... > > 64, 80, or 113-bit significands? > > > > I don't know either (for some reason I'm thinking long double is synonym > for double on arm, but I can't remember why I think that). > > This compile failure isn't just arm, btw, it's also powerpc and mips. > sparc and x86 seem to be okay. > Inspection of the various _fpmath.h files shows that failures are on long double == double platforms. Can you test this patch? Index: Makefile =================================================================== --- Makefile (revision 257810) +++ Makefile (working copy) @@ -71,7 +71,7 @@ s_lround.c s_lroundf.c s_lroundl.c s_modff.c \ s_nan.c s_nearbyint.c s_nextafter.c s_nextafterf.c \ s_nexttowardf.c s_remquo.c s_remquof.c \ - s_rint.c s_rintf.c s_round.c s_roundf.c s_roundl.c \ + s_rint.c s_rintf.c s_round.c s_roundf.c \ s_scalbln.c s_scalbn.c s_scalbnf.c s_signbit.c \ s_signgam.c s_significand.c s_significandf.c s_sin.c s_sinf.c \ s_tan.c s_tanf.c s_tanh.c s_tanhf.c s_tgammaf.c s_trunc.c s_truncf.c \ @@ -101,7 +101,7 @@ s_asinhl.c s_atanl.c s_cbrtl.c s_ceill.c s_cosl.c s_cprojl.c \ s_csqrtl.c s_exp2l.c s_expl.c s_floorl.c s_fmal.c \ s_frexpl.c s_logbl.c s_logl.c s_nanl.c s_nextafterl.c \ - s_nexttoward.c s_remquol.c s_rintl.c s_scalbnl.c \ + s_nexttoward.c s_remquol.c s_rintl.c s_roundl.c s_scalbnl.c \ s_sinl.c s_tanl.c s_truncl.c w_cabsl.c .endif Index: src/s_round.c =================================================================== --- src/s_round.c (revision 257810) +++ src/s_round.c (working copy) @@ -52,3 +52,7 @@ return (-t); } } + +#if (LDBL_MANT_DIG == 53) +__weak_reference(round, roundl); +#endif -- Steve