Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Sep 2018 13:12:24 +0200
From:      Stefan Esser <se@freebsd.org>
To:        Jakob Breivik Grimstveit <jakob@grimstveit.no>
Cc:        FreeBSD Ports mailing list <freebsd-ports@freebsd.org>
Subject:   Re: Error building net/librsync2
Message-ID:  <6797c7a2-6f73-ab54-6695-99f67716d4ca@freebsd.org>
In-Reply-To: <CAFVH1KUTvXZ1YyV7Ep_TP99vcYjj%2B3ABHeUNM5q0SwFsVVahNg@mail.gmail.com>
References:  <CAFVH1KUTvXZ1YyV7Ep_TP99vcYjj%2B3ABHeUNM5q0SwFsVVahNg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Am 18.09.18 um 12:23 schrieb Jakob Breivik Grimstveit:
> $ uname -a
> FreeBSD core2.grimstveit.no 11.2-RELEASE-p3 FreeBSD 11.2-RELEASE-p3 #7
> r338607: Wed Sep 12 13:24:12 CEST 2018
> root@core2.grimstveit.no:/usr/obj/usr/src/sys/CORE2
> amd64
> 
> [...]
> [22/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc
> -O2 -pipe -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2
> -pipe -march=native  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT
> CMakeFiles/rsync.dir/src/scoop.c.o -MF CMakeFiles/rsync.dir/src/scoop.c.o.d
> -o CMakeFiles/rsync.dir/src/scoop.c.o   -c src/scoop.c
> [23/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc
> -O2 -pipe -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2
> -pipe -march=native  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT
> CMakeFiles/rsync.dir/src/version.c.o -MF
> CMakeFiles/rsync.dir/src/version.c.o.d -o
> CMakeFiles/rsync.dir/src/version.c.o   -c src/version.c
> [24/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc
> -O2 -pipe -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2
> -pipe -march=native  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT
> CMakeFiles/rsync.dir/src/util.c.o -MF CMakeFiles/rsync.dir/src/util.c.o.d
> -o CMakeFiles/rsync.dir/src/util.c.o   -c src/util.c
> [25/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc
> -O2 -pipe -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2
> -pipe -march=native  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT
> CMakeFiles/rsync.dir/src/mdfour.c.o -MF
> CMakeFiles/rsync.dir/src/mdfour.c.o.d -o
> CMakeFiles/rsync.dir/src/mdfour.c.o   -c src/mdfour.c
> [26/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc
> -O2 -pipe -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2
> -pipe -march=native  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT
> CMakeFiles/rsync.dir/src/trace.c.o -MF CMakeFiles/rsync.dir/src/trace.c.o.d
> -o CMakeFiles/rsync.dir/src/trace.c.o   -c src/trace.c
> [27/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc
> -O2 -pipe -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2
> -pipe -march=native  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT
> CMakeFiles/rsync.dir/src/tube.c.o -MF CMakeFiles/rsync.dir/src/tube.c.o.d
> -o CMakeFiles/rsync.dir/src/tube.c.o   -c src/tube.c
> [28/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc
> -O2 -pipe -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2
> -pipe -march=native  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT
> CMakeFiles/rsync.dir/src/whole.c.o -MF CMakeFiles/rsync.dir/src/whole.c.o.d
> -o CMakeFiles/rsync.dir/src/whole.c.o   -c src/whole.c
> [29/53] /usr/bin/cc  -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -MD -MT
> CMakeFiles/sumset_test.dir/tests/sumset_test.c.o -MF
> CMakeFiles/sumset_test.dir/tests/sumset_test.c.o.d -o
> CMakeFiles/sumset_test.dir/tests/sumset_test.c.o   -c tests/sumset_test.c
> FAILED: CMakeFiles/sumset_test.dir/tests/sumset_test.c.o
> /usr/bin/cc  -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -MD -MT
> CMakeFiles/sumset_test.dir/tests/sumset_test.c.o -MF
> CMakeFiles/sumset_test.dir/tests/sumset_test.c.o.d -o
> CMakeFiles/sumset_test.dir/tests/sumset_test.c.o   -c tests/sumset_test.c
> In file included from tests/sumset_test.c:27:
> /usr/local/include/librsync.h:430:21: error: unknown type name 'FILE'
> void rs_mdfour_file(FILE *in_file, char *result);
>                     ^
> /usr/local/include/librsync.h:432:23: error: unknown type name 'FILE'
> rs_result rs_sig_file(FILE *old_file, FILE *sig_file,
>                       ^
> /usr/local/include/librsync.h:432:39: error: unknown type name 'FILE'
> rs_result rs_sig_file(FILE *old_file, FILE *sig_file,
>                                       ^
> /usr/local/include/librsync.h:437:27: error: unknown type name 'FILE'
> rs_result rs_loadsig_file(FILE *, rs_signature_t **, rs_stats_t *);
>                           ^
> /usr/local/include/librsync.h:441:43: error: unknown type name 'FILE'
> rs_result rs_delta_file(rs_signature_t *, FILE *new_file, FILE *delta_file,
> rs_stats_t *);
>                                           ^
> /usr/local/include/librsync.h:441:59: error: unknown type name 'FILE'
> rs_result rs_delta_file(rs_signature_t *, FILE *new_file, FILE *delta_file,
> rs_stats_t *);
>                                                           ^
> /usr/local/include/librsync.h:443:25: error: unknown type name 'FILE'
> rs_result rs_patch_file(FILE *basis_file, FILE *delta_file, FILE *new_file,
> rs_stats_t *);
>                         ^
> /usr/local/include/librsync.h:443:43: error: unknown type name 'FILE'
> rs_result rs_patch_file(FILE *basis_file, FILE *delta_file, FILE *new_file,
> rs_stats_t *);
>                                           ^
> /usr/local/include/librsync.h:443:61: error: unknown type name 'FILE'
> rs_result rs_patch_file(FILE *basis_file, FILE *delta_file, FILE *new_file,
> rs_stats_t *);
>                                                             ^
> 9 errors generated.
> [30/53] /usr/bin/cc  -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -MD -MT
> CMakeFiles/sumset_test.dir/src/util.c.o -MF
> CMakeFiles/sumset_test.dir/src/util.c.o.d -o
> CMakeFiles/sumset_test.dir/src/util.c.o   -c src/util.c
> [31/53] /usr/bin/cc  -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -MD -MT
> CMakeFiles/sumset_test.dir/src/hex.c.o -MF
> CMakeFiles/sumset_test.dir/src/hex.c.o.d -o
> CMakeFiles/sumset_test.dir/src/hex.c.o   -c src/hex.c
> [32/53] /usr/bin/cc  -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -MD -MT
> CMakeFiles/sumset_test.dir/src/trace.c.o -MF
> CMakeFiles/sumset_test.dir/src/trace.c.o.d -o
> CMakeFiles/sumset_test.dir/src/trace.c.o   -c src/trace.c
> [33/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc
> -O2 -pipe -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2
> -pipe -march=native  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT
> CMakeFiles/rsync.dir/src/sumset.c.o -MF
> CMakeFiles/rsync.dir/src/sumset.c.o.d -o
> CMakeFiles/rsync.dir/src/sumset.c.o   -c src/sumset.c
> [34/53] /usr/bin/cc  -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -MD -MT
> CMakeFiles/sumset_test.dir/src/checksum.c.o -MF
> CMakeFiles/sumset_test.dir/src/checksum.c.o.d -o
> CMakeFiles/sumset_test.dir/src/checksum.c.o   -c src/checksum.c
> [35/53] /usr/bin/cc  -I/usr/local/include -Isrc/blake2 -Isrc -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2 -pipe
> -march=native  -fstack-protector -fno-strict-aliasing -MD -MT
> CMakeFiles/sumset_test.dir/src/sumset.c.o -MF
> CMakeFiles/sumset_test.dir/src/sumset.c.o.d -o
> CMakeFiles/sumset_test.dir/src/sumset.c.o   -c src/sumset.c
> [36/53] /usr/bin/cc -Drsync_EXPORTS -I/usr/local/include -Isrc/blake2 -Isrc
> -O2 -pipe -march=native  -fstack-protector -fno-strict-aliasing -Wall -O2
> -pipe -march=native  -fstack-protector -fno-strict-aliasing -fPIC -MD -MT
> CMakeFiles/rsync.dir/src/blake2/blake2b-ref.c.o -MF
> CMakeFiles/rsync.dir/src/blake2/blake2b-ref.c.o.d -o
> CMakeFiles/rsync.dir/src/blake2/blake2b-ref.c.o   -c
> src/blake2/blake2b-ref.c
> ninja: build stopped: subcommand failed.
> ===> Compilation failed unexpectedly.
> Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
> the maintainer.
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/ports/net/librsync2
> 
> ===>>> make build failed for net/librsync2
> ===>>> Aborting update
> 
> ===>>> Update for net/librsync2 failed
> ===>>> Aborting update
> 
> 
> ===>>> You can restart from the point of failure with this command line:
>        portmaster <flags> net/librsync2
> 
> This command has been saved to /tmp/portmasterfail.txt
> 
> librsync2-2.0.0_1                  <

This is the 2nd report of this issue, but I cannot reproduce it on my
amd64-CURRENT system.

This might be caused by stdio.h being included by header-pollution on
some but not all FreeBSD versions.

Try adding "#include <stdio.h>" at the top of tests/sumset_test.c:

--- tests/sumset_test.c.orig	2018-02-27 11:08:36.000000000 +0100
+++ tests/sumset_test.c	2018-09-18 13:10:48.295360000 +0200
@@ -22,6 +22,7 @@
 /* Force DEBUG on so that tests can use assert(). */
 #undef NDEBUG
 #include "config.h"
+#include <stdio.h>
 #include <string.h>
 #include <assert.h>
 #include "librsync.h"

Regards, STefan




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6797c7a2-6f73-ab54-6695-99f67716d4ca>